Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xcode 13.3] Fix for artifact not found for target #2

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

PinkidG
Copy link
Contributor

@PinkidG PinkidG commented Mar 10, 2022

Problem

With the upcoming version of Xcode 13.3 there seems to be a new behaviour for binary targets. It will throw an error (artifact not found for target ) if the xcframework file name is not identical with the binary target name.

Screenshot 2022-03-10 at 11 24 07

Proposed fix

Renamed the xcframework to CertificateSDKPackage.xcframework and adjust the path parameter of the Package.swift.

An alternative would be to rename the package completely and keep the name of the xcframework. This however might cause conflicts with projects that use the framework.

Reference

There is no real public documentation for this change, only one other thread here.

I was able to verify that fix solves the issue on Xcode 13.3 RC.

@macblazer macblazer self-assigned this Mar 10, 2022
Copy link
Contributor

@macblazer macblazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR for this, but there's a simpler fix that is a little better in the long run. If you want to remove the rename of the .xcframework file, then modify the two lines in the Package.swift we can accept this contribution.

Projects using the .xcframework directly (not through Swift Package Manager) are not impacted by a simple two line change to the Package.swift file.

Package.swift Outdated Show resolved Hide resolved
@PinkidG
Copy link
Contributor Author

PinkidG commented Mar 11, 2022

As requested, I simply removed the Package suffix everywhere, seems to work just as well. 🙂

Copy link
Contributor

@macblazer macblazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@macblazer macblazer merged commit d616cb1 into jamf:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xcode 13.3 cannot resolve the binary target artifact when using Swift Package Manager
2 participants