Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long code signing requirements are not fully displayed #54

Closed
macblazer opened this issue May 11, 2020 · 1 comment · Fixed by #82 or ty-wilson/PPPC-Utility#8
Closed

Long code signing requirements are not fully displayed #54

macblazer opened this issue May 11, 2020 · 1 comment · Fixed by #82 or ty-wilson/PPPC-Utility#8
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@macblazer
Copy link
Contributor

As a user of this app I would like the full code signing requirement to be displayed for the selected item so that I understand exactly what the full requirement is.

Currently when an item is selected in the left-most list, it's name, bundle identifier, and code signing requirement are displayed in the top of the window. The code signing requirement is given two lines of text to display, and if it is longer then the top half of a third line will display (sometimes). This is especially noticeable when the window is shrunk to it's minimum horizontal size. Jamf Pro's Self Service app has a long requirement; Sublime Text also has a long requirement.

We could either cap it at two lines and give some indicator that there is more with a hover displaying the full text, or we could make the requirement scrollable, or we could have it auto-expand to more lines as needed. The auto-expand would still probably require some hard upper limit (so the rest of the controls are still usable) so the hover or scrollable solution would be needed anyway for really really long requirements.

@macblazer macblazer added the bug Something isn't working label May 11, 2020
@macblazer macblazer added the good first issue Good for newcomers label May 18, 2020
@macblazer
Copy link
Contributor Author

macblazer commented May 18, 2020

I believe the easiest solution here is to simply

  1. Truncate the label with ellipses after two lines,
  2. Bind the tooltip field to the same thing as the value.
  3. Fix the resizing to always be two lines only instead of sometimes showing half of a third line.

Note: Those top fields seem to extend all the way to the right edge of the window. It would be extra nice if while fixing this display issue the right side of the fields was pushed in from the right edge the standard padding width.

ty-wilson added a commit to ty-wilson/PPPC-Utility that referenced this issue Oct 23, 2020
Added to the code requirement label:
> truncates
> maximum of 2 lines
> tooltip binding
> padding on right edge
@watkyn watkyn linked a pull request Oct 26, 2020 that will close this issue
@watkyn watkyn closed this as completed in #82 Nov 2, 2020
watkyn pushed a commit that referenced this issue Nov 2, 2020
* Update TCCProfileViewController.swift

Fix #62

* Fix #54

Added to the code requirement label:
> truncates
> maximum of 2 lines
> tooltip binding
> padding on right edge

* Fix #79

Updated All Files to Full Disk Access

* Update project.pbxproj

Revert Code Signing Identity

* Fix #83

Bind the Apple Events Table Selection Index to the AppleEventsAC Selection Index

* Update to Properties Names and Descriptions

Changes the following property names to reflect their names in System Preferences:
All Files > Full Disk Access
Address Book > Contacts
Calendar > Calendars
Listen Event > Input Monitoring
Screen Capture > Screen Recording

Added MDM Keys to the help button for each property (ProfilesDescriptions.swift)

Rearranged the new property names alphabetically and updated the backgrounds
ty-wilson added a commit to ty-wilson/PPPC-Utility that referenced this issue Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant