Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multipart uploads #78

Merged
merged 1 commit into from Jan 18, 2018
Merged

Add support for multipart uploads #78

merged 1 commit into from Jan 18, 2018

Conversation

leontastic
Copy link
Collaborator

Resolves #33

Multipart uploads is a major feature missing from this mock S3 server. Without it, it's impossible to test uploading files larger than 5MB using aws-sdk:

const s3 = new AWS.S3()
// ...
s3.upload(params, (err, data) => {})

@n1ru4l
Copy link
Collaborator

n1ru4l commented Jan 17, 2018

Awesome exactly what I need 😅
Build is failing due to ancient nodejs version.

@n1ru4l
Copy link
Collaborator

n1ru4l commented Jan 18, 2018

I created #79 to update the nodejs runtime.

@leontastic leontastic merged commit 603be9f into jamhall:master Jan 18, 2018
n1ru4l added a commit that referenced this pull request Jan 18, 2018
n1ru4l added a commit that referenced this pull request Jan 18, 2018
docs(README): Document feature added in #78
This was referenced Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants