MudScrollToTop: Fix Exception When Changing Page (MudBlazor#5060)

jammerware · Sep 20, 2022 · 66161dd · 66161dd
1 parent 5d6f963
commit 66161dd
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/MudBlazor/TScripts/mudScrollListener.js b/src/MudBlazor/TScripts/mudScrollListener.js
@@ -7,6 +7,8 @@ class MudScrollListener {
 
     constructor() {
         this.throttleScrollHandlerId = -1;
+        //needed as variable to remove the event listeners
+        this.handlerRef = null;
     }
 
     // subscribe to throttled scroll event
@@ -16,10 +18,11 @@ class MudScrollListener {
             ? document.querySelector(selector)
             : document;
 
+        this.handlerRef = this.throttleScrollHandler.bind(this, dotnetReference);
         // add the event listener
         element.addEventListener(
             'scroll',
-            this.throttleScrollHandler.bind(this, dotnetReference),
+            this.handlerRef,
             false
         );
     }
@@ -54,7 +57,6 @@ class MudScrollListener {
             //data to pass
             let firstChild = element.firstElementChild;
             let firstChildBoundingClientRect = firstChild.getBoundingClientRect();
-
             //invoke C# method
             dotnetReference.invokeMethodAsync('RaiseOnScroll', {
                 firstChildBoundingClientRect,
@@ -73,9 +75,9 @@ class MudScrollListener {
     cancelListener(selector) {
         let element = selector
             ? document.querySelector(selector)
-            : document.documentElement;
+            : document;
 
-        element.removeEventListener('scroll', this.throttleScrollHandler);
+        element.removeEventListener('scroll', this.handlerRef);
     }
 };
 window.mudScrollListener = new MudScrollListener();