-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Fails to detect existing configuration and overwrites it with default template #10
Comments
The standard config is copied every start on purpose, so you get the latest config and not a "not working server". |
I have the same issue and even after updated my compose file, the configuration file has not been modified with the compose values. I overwrote my compose env variables with the one in the readme. |
The latest version of the container allows for setting the SERVER_PASSWORD envvar, which should then be copied to the conf file :) |
On systems like TrueNAS Scale, the environment variable can't be blank. So how can we make it a public server without a password? |
Disregard. Double quotes works. |
Hey @Lakio21 |
@redeven if have fixed a lot of bugs, this should be better now i hope, please review and let me know. Please go ahead and test things. |
@jammsen Sorry for the late reponse. It was a little urgent so I end up forking your repo and revert to the previous state to make the server quickly up and running. I will give it ago later when I have more free time. |
If this issue is solved, please give me feedback on the patch and please consider giving me a Star here and on Docker-Hub. |
Ping |
What would be the best way to update the server options that are not covered by the env vars in the game? For example |
Please use
@gchai If you need other variables you are free to open an issue and i will look into that OR you join the issue #29 which "maybe wants" to have a "dumb" or "manual" mode to not use ENVs but only the config-file itself to be manually edited. Not sure what the requestor really wanted. But a manual/dum mode would be possible, while the ENVs way is considered Best-Practice in all of Docker and K8s / Twelve-Factor-App |
I can add all the variables in as a Env Var and make a PR! |
#40 submitted! |
Hey @gchai |
This behavior should be solved with 8546c89#diff-3b41cd2eeb76ac64c4b71b9cc6b253b358ab737f50d54e333b631ca27357e98e Feel free to reopen the issue if the problem persists. If you like this project, please consider giving this repo and the docker-hub-repo a Star. |
Have you read the Important information text above
Current behavior
Despite having existing config files mounted, it fails to detect them and overwrites them with the template, every single time.
This has started happening today (likely related to #5), after the docker image was updated.
Desired behavior
Existing mounted config files should be respected.
Links to screenshots
To Reproduce
Software setup
Hardware setup
Additional context
No response
The text was updated successfully, but these errors were encountered: