-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker shutdown signal not passed on #14
Comments
This would be helpful since the server needs rebooted every 2 hours due to memory leak. |
Hey @uncaught |
Yes, your entrypoint ( I don't know where - ./PalServer.sh "$START_OPTIONS"
+ exec ./PalServer.sh "$START_OPTIONS"
Not sure if you need your own process running still though. |
Hey @uncaught
But im working on a fix for that, a collegue of mine has something the might work and he was okay with me using it. |
Fix is applied in my local version: Console
3.3 instead of 10 🚀 docker-compose logs -f
This should do the trick i think. @uncaught |
3.3 seconds sounds good :) |
Please go ahead and test things. |
If this issue is solved, please give me feedback on the patch and please consider giving me a Star here and on Docker-Hub. |
@uncaught Ping please read the last 2 comments and tell me things |
I've seen it, but can't test, yet. I've been shutting down the server via rcon lately and it's not running right now. (Damn memory leak ;) ) I've been using the updated script though already since yesterday. I'm going to assume this is solved (until they change the name of |
Well its their binary and their shell-script, up to them to manage that beast, hehe 👍 |
Have you read the Important information text above
Current behavior
When stopping the container, it seems to get killed after the
stop_grace_period
(default 10s).Desired behavior
The stop signal should be passed onto the underlying service so that it shuts down cleanly within the grace period.
If the clean shutdown takes longer than 10 seconds, the image should set a higher grace period.
Links to screenshots
No response
To Reproduce
Steps to reproduce the behavior:
Software setup
Hardware setup
Additional context
No response
The text was updated successfully, but these errors were encountered: