Don't terminate if we already are #778
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| if termination == TerminationKind::Soft && kind == TerminationKind::Soft { | ||
| // We are already soft-terminating, don't change the kind. | ||
| return Ok(()); | ||
| } |
There was a problem hiding this comment.
We currently already have a check in to_terminating that makes sure a hard terminate can't turn into a soft terminate. Maybe it makes sense to protect against sending more than one soft terminate, but I'm worried about dropping out here on a hard terminate. One reason is that the set_state call is one spot where we can actually detect that a hard terminating backend no longer exists and mark it as terminated. If a backend reaches a hard terminating state but we miss the event from docker to mark it as terminated, then I don't see a way the drone can ever mark the backend as terminated if we're dropping out here.
There was a problem hiding this comment.
Hmm good point, I'll mark this as a draft and have another think through it.
|
Have we observed a user-facing problem that we're trying to fix with this PR? Have we seen several sigints being sent to the same backend? |
This prevents us from going from hard-terminating to soft-terminating, and from sending multiple SIGINTs.