-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add presence hook and barebones demo to test it #15
Merged
paulgb
merged 10 commits into
main
from
paul/dis-1135-add-presence-hook-to-react-library
Jul 27, 2023
Merged
Add presence hook and barebones demo to test it #15
paulgb
merged 10 commits into
main
from
paul/dis-1135-add-presence-hook-to-react-library
Jul 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIS-1135 Add presence hook to React library
Should work like:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…thub.com:drifting-in-space/y-serve into paul/dis-1135-add-presence-hook-to-react-library
rolyatmax
reviewed
Jul 27, 2023
rolyatmax
reviewed
Jul 27, 2023
rolyatmax
reviewed
Jul 27, 2023
rolyatmax
reviewed
Jul 27, 2023
rolyatmax
reviewed
Jul 27, 2023
rolyatmax
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a presence hook. Keeps the existing awareness hook to obtain the raw
Awareness
value (useful for passing to components like CodeMirror), but adds ausePresence
hook that works like we discussed.The demo is just there to confirm that it works; feel free to run with it and turn it into something cooler.