Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recording support with Reaper Project generation #1

Conversation

pljones
Copy link
Collaborator

@pljones pljones commented Apr 3, 2019

Includes the following changes

  • Initial .gitignore
    Administrative

  • Fix up warning message

  • Not all Windows file systems are case insensitive
    Bugfixes

  • (Qt5) Use QCoreApplication for headless
    Possible solution to get the application to run as a headless server but it loses the nice history graph, so not ideal.

  • Avoid ESC closing chat
    Because ESC shouldn't close the chat window. Or the main app window.

  • Add console logging support for Windows
    Whilst looking for the headless support, I found this idea for Windows logging. New improved version. This makes far fewer changes.


  • Add recording support with Reaper Project generation
    The main feature!
    • New -r option to enable recording of PCM files and conversion to Reaper RPP with WAV files
    • New -R option to set the directory in which to create recording sessions
      You need to specify the -R option, there's no default... so I guess -r and -R could be combined.
    • New -T option to convert a session directory with PCM files into a Reaper RPP with WAV files
      You can use -T on "failed" sessions, if the -r option captures the PCMs but the RPP converter doesn't run for some reaon. (It was useful during development, maybe less so once things seem stable.)

The recorder is implemented as a new thread with queuing from the main "real time" server thread.

When a new client connects or if its audio format changes (e.g. mono to stereo), a new RIFF WAVE file is started. Each frame of decompressed audio for each client written out as LPCM to the file. When the client disconnects, the RIFF WAVE headers are updated to reflect the file length.

Once all clients disconnect, the session is considered ended and a Reaper RPP file is written.

pljones and others added 2 commits April 3, 2019 18:12
Includes the following changes

* Initial .gitignore
Administrative

* Fix up warning message
* Not all Windows file systems are case insensitive
Bugfixes

* (Qt5) Use QCoreApplication for headless
Possible solution to get the application to run as a headless server but it loses the nice history graph, so not ideal.

* Avoid ESC closing chat
Because ESC shouldn't close the chat window. Or the main app window.

* Add console logging support for Windows
Whilst looking for the headless support, I found this idea for Windows logging.  New improved version.  This makes far fewer changes.

----

* Add recording support with Reaper Project generation
The main feature!
    * New -r option to enable recording of PCM files and conversion to Reaper RPP with WAV files
    * New -R option to set the directory in which to create recording sessions
    You need to specify the -R option, there's no default... so I guess -r and -R could be combined.
    * New -T option to convert a session directory with PCM files into a Reaper RPP with WAV files
    You can use -T on "failed" sessions, if the -r option captures the PCMs but the RPP converter doesn't run for some reaon. (It was useful during development, maybe less so once things seem stable.)

The recorder is implemented as a new thread with queuing from the main "real time" server thread.

When a new client connects or if its audio format changes (e.g. mono to stereo), a new RIFF WAVE file is started.  Each frame of decompressed audio for each client written out as LPCM to the file.  When the client disconnects, the RIFF WAVE headers are updated to reflect the file length.

Once all clients disconnect, the session is considered ended and a Reaper RPP file is written.
@pljones pljones closed this Apr 3, 2019
@pljones pljones reopened this Apr 3, 2019
@pljones
Copy link
Collaborator Author

pljones commented Apr 8, 2019

Sorry, wrong place for the pull origin.

@pljones pljones closed this Apr 8, 2019
corrados pushed a commit that referenced this pull request Apr 10, 2019
@corrados
Copy link
Contributor

corrados commented Apr 12, 2019

You need to specify the -R option, there's no default... so I guess -r and -R could be combined.

I only use the -R option on my branch. If with -R a directory is given, the recording is started. So I removed the -r option.

You can use -T on "failed" sessions, if the -r option captures the PCMs but the RPP converter doesn't run for some reaon. (It was useful during development, maybe less so once things seem stable.)

I will remove it on my integration branch.

@pljones
Copy link
Collaborator Author

pljones commented Apr 13, 2019

You need to specify the -R option, there's no default... so I guess -r and -R could be combined.

I only use the -R option on my branch. If with -R a directory is given, the recording is started. So I removed the -r option.

The only thing I thought of is that -R <dir> could mean "record the WAV files into <dir>" and -r could mean "create a Reaper RPP" (maybe switching -r and -R), which would allow for adding support for other project formats in future... but as it's only Reaper, there's no reason to mess things around currently.

@pljones pljones deleted the feature/pljones-audio-stream-saving branch April 13, 2019 16:56
@mirabilos mirabilos mentioned this pull request Apr 19, 2020
@dcocharro dcocharro mentioned this pull request Apr 20, 2020
corrados pushed a commit that referenced this pull request May 7, 2020
corrados pushed a commit that referenced this pull request May 10, 2020
Merge pull request #191 from ignotus666/master
corrados pushed a commit that referenced this pull request May 22, 2020
corrados pushed a commit that referenced this pull request May 24, 2020
Merge New Features on my fork
corrados pushed a commit that referenced this pull request Jun 5, 2020
corrados pushed a commit that referenced this pull request Jun 8, 2020
corrados pushed a commit that referenced this pull request Jun 19, 2020
corrados pushed a commit that referenced this pull request Jun 20, 2020
corrados pushed a commit that referenced this pull request Jun 27, 2020
corrados pushed a commit that referenced this pull request Jul 6, 2020
corrados pushed a commit that referenced this pull request Jul 17, 2020
corrados pushed a commit that referenced this pull request Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants