Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Bump actions/checkout from 2 to 3 #2799

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 22, 2022

Bumps actions/checkout from 2 to 3.

Release notes

Sourced from actions/checkout's releases.

v3.0.0

  • Updated to the node16 runtime by default
    • This requires a minimum Actions Runner version of v2.285.0 to run, which is by default available in GHES 3.4 or later.

v2.4.2

What's Changed

Full Changelog: actions/checkout@v2...v2.4.2

v2.4.1

  • Fixed an issue where checkout failed to run in container jobs due to the new git setting safe.directory

v2.4.0

  • Convert SSH URLs like org-<ORG_ID>@github.com: to https://github.com/ - pr

v2.3.5

Update dependencies

v2.3.4

v2.3.3

v2.3.2

Add Third Party License Information to Dist Files

v2.3.1

Fix default branch resolution for .wiki and when using SSH

v2.3.0

Fallback to the default branch

v2.2.0

Fetch all history for all tags and branches when fetch-depth=0

v2.1.1

Changes to support GHES (here and here)

v2.1.0

... (truncated)

Changelog

Sourced from actions/checkout's changelog.

Changelog

v3.0.2

v3.0.1

v3.0.0

v2.3.1

v2.3.0

v2.2.0

v2.1.1

  • Changes to support GHES (here and here)

v2.1.0

v2.0.0

v2 (beta)

  • Improved fetch performance

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 22, 2022
@ann0see ann0see added this to the Release 3.9.1 milestone Aug 22, 2022
@ann0see ann0see added this to Triage in Tracking (old) via automation Aug 22, 2022
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/checkout-3 branch from 3bc20fd to 1d75928 Compare August 22, 2022 19:02
@ann0see
Copy link
Member

ann0see commented Aug 22, 2022

after a second review, I'd like to see how the dependabot merge command is different to a normal click on the merge button.

Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ann0see Go ahead ;)

Tracking (old) automation moved this from Triage to In Progress Aug 22, 2022
@ann0see
Copy link
Member

ann0see commented Aug 22, 2022

@dependabot merge

@dependabot dependabot bot merged commit bec8c63 into master Aug 22, 2022
Tracking (old) automation moved this from In Progress to Done Aug 22, 2022
@dependabot dependabot bot deleted the dependabot/github_actions/actions/checkout-3 branch August 22, 2022 19:59
@ann0see
Copy link
Member

ann0see commented Aug 22, 2022

Probably it's just the merger who changes.

@hoffie
Copy link
Member

hoffie commented Aug 22, 2022

And it seems like it changes the context for CI runs -- looks like the dependabot-triggered action lacks access to the secrets required for the dependencies bump check?

https://github.com/jamulussoftware/jamulus/runs/7960101624?check_suite_focus=true#step:2:53

@hoffie
Copy link
Member

hoffie commented Aug 22, 2022

The regular merge of the other PR did not have this issue. So I guess we should go with regular merges.

@hoffie
Copy link
Member

hoffie commented Aug 22, 2022

For PRs, this is documented behavior, btw. Might be similar for the merges then.

Workflow runs triggered by Dependabot pull requests run as if they are from a forked repository, and therefore use a read-only GITHUB_TOKEN. These workflow runs cannot access any secrets.

@hoffie hoffie changed the title CI: Bump actions/checkout from 2 to 3 Build: Bump actions/checkout from 2 to 3 Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants