Install JACK via web request #3003
Conversation
|
GH might not be worth the hassle. Using a simple web request is easier. |
ann0see
force-pushed
the
moveJacktoGH
branch
9 times, most recently
from
d445b84
to
49b63bc
Compare
|
Ok. I think this is ready for review now @henkdegroot |
| get_upstream_version: | | ||
| curl -s -o /dev/null --location --range 0-5 --write-out '%{url_effective}' https://community.chocolatey.org/api/v2/package/jack/ | | ||
| grep -oP '.*/jack\.\K.*(?=\.nupkg)' | ||
| get_upstream_version: GH_REPO=jackaudio/jack2-releases gh release view --json tagName --jq .tagName | sed -re 's/^v//' |
There was a problem hiding this comment.
@hoffie I think this needs some verification from your end. I copied it from the other GitHub dependency.
|
Tested on Win 11 and it seems to be all right. |
|
No surprise here....I tested on Win 10 and working fine here as well. |
|
I'm tempted to say just get this merged... |
|
@pljones feel free to review and merge. |
|
|
||
| if ( !$? ) | ||
| { | ||
| throw "Download of "+ $Name + " (" + $Uri + ") failed with exit code $LastExitCode" |
There was a problem hiding this comment.
Why mixed syntax of variable expansion?
There was a problem hiding this comment.
Not important, resolving.
There was a problem hiding this comment.
Thanks. Unresolving them for convenience.
#3012
| if ( !$? ) | ||
| { | ||
| throw "64bit jack installation failed with exit code $LastExitCode" | ||
| throw "64bit JACK installer failed with exit code $LastExitCode" | ||
| } else { |
There was a problem hiding this comment.
No need for else block around the echo.
There was a problem hiding this comment.
Not important, resolving.
| throw "32bit jack installation failed with exit code $LastExitCode" | ||
| throw "32bit JACK installer failed with exit code $LastExitCode" | ||
| } else { | ||
| echo "32bit JACK installation completed successfully" |
There was a problem hiding this comment.
Not important, resolving.
| get_upstream_version: | | ||
| curl -s -o /dev/null --location --range 0-5 --write-out '%{url_effective}' https://community.chocolatey.org/api/v2/package/jack/ | | ||
| grep -oP '.*/jack\.\K.*(?=\.nupkg)' | ||
| get_upstream_version: GH_REPO=jackaudio/jack2-releases gh release view --json tagName --jq .tagName | sed -re 's/^v//' |
Improve updated JACK autobuild (#3003)
Short description of changes
As the choco build doesn't seem to get updated, this is an alternative approach to install JACK via cli. The download is done via
gha web request in PowerShell and the installation is done via the normal installer.CHANGELOG: Internal: The JACK build will now install directly from the JACK GitHub repository
Context: Fixes an issue?
Fixes: #2992
Does this change need documentation? What needs to be documented and how?
Don't think so.
Status of this Pull Request
Ready for review. Needs to be tested.
Moreover we might need to implement cachingTested and works.What is missing until this pull request can be merged?
Check if the automated update works (bump-dependencies)
Checklist
AUTOBUILD: Please build all targets