Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve updated JACK autobuild (#3003) #3014

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Feb 14, 2023

Short description of changes
Post merge #3003 applies comments by @pljones

CHANGELOG: Internal: The JACK build will now install directly from the JACK GitHub repository

Context: Fixes an issue?

Fixes: #3012

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Ready for review

What is missing until this pull request can be merged?

Review

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see added this to Triage in Tracking (old) via automation Feb 14, 2023
@ann0see ann0see added this to the Release 3.10.0 milestone Feb 14, 2023
@ann0see ann0see requested a review from pljones February 14, 2023 21:45
@ann0see ann0see moved this from Triage to Waiting on Team in Tracking (old) Feb 14, 2023
@pljones
Copy link
Collaborator

pljones commented Feb 15, 2023

Looks good, force merging.

Downloading 64 Bit and 32 Bit JACK installer (if needed)...
Installing JACK2 64-bit...
64bit JACK installation completed successfully
Installing JACK2 32-bit...
32bit JACK installation completed successfully

@pljones pljones merged commit f1c1500 into jamulussoftware:main Feb 15, 2023
Tracking (old) automation moved this from Waiting on Team to Done Feb 15, 2023
@ann0see ann0see deleted the update-jack branch February 16, 2023 08:23
@pljones pljones removed this from Done in Tracking (old) Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

POST MERGE review for JACK pr
2 participants