Build: Update iOS Runner and SDK #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
macos-11 with xcode 12.4/12.5.1 might also work and is a smaller step |
This updates the iOS build to a newer SDK which is not supported by Qt5. Due to ongoing work on Qt6 support, this is a hotfix only with the goal to have a fully working Qt6 iOS build in future.
|
Ok. With this change everything works as expected (no crash, UI ok - by that I mean actually usable) |
|
@ngocdh could you please test this version too? I believe Qt5 works and this is a working version. |
pljones
approved these changes
May 22, 2023
|
Merging as meets spec and clean build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
This updates the iOS build to a newer SDK. Due to ongoing work on Qt6 support, this is a hotfix only with the goal to have a fully working Qt6 iOS build in future.
CHANGELOG: iOS: Build App with higher SDK version.
Context: Fixes an issue?
Fixes: #2939 (ONLY this one. Doesn't upgrade the Qt version)
Related to: #3065
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
Ready for merge
What is missing until this pull request can be merged?
Tested on my device and is ok. Therefore I think it’s fine to get in.
Checklist