Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpenAPI v2 null support #298

Merged
merged 2 commits into from
Apr 26, 2020
Merged

Fix OpenAPI v2 null support #298

merged 2 commits into from
Apr 26, 2020

Conversation

Korbeil
Copy link
Member

@Korbeil Korbeil commented Apr 24, 2020 •
edited
Loading

Fixes #297

OpenAPI v2 does not support null type. We should use custom field such as x-nullable. See https://stackoverflow.com/a/48114322 for more details.

  • Remove null support in OpenAPI v2
  • Add x-nullable support
  • Documentation about nullable support in all libraries

@Korbeil Korbeil added the WIP label Apr 24, 2020
@Korbeil Korbeil self-assigned this Apr 24, 2020
@Korbeil Korbeil removed the WIP label Apr 24, 2020
@Korbeil Korbeil marked this pull request as ready for review April 25, 2020 17:46
@Korbeil Korbeil merged commit 80e80fd into janephp:master Apr 26, 2020
@Korbeil Korbeil deleted the fix/nullable-handling branch April 26, 2020 19:06
@Korbeil Korbeil restored the fix/nullable-handling branch April 26, 2020 19:07
@Korbeil Korbeil deleted the fix/nullable-handling branch May 6, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Korbeil Korbeil

Labels
review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenAPI v2 null support
1 participant
@Korbeil