[JsonSchema] Rework Validation (part1) #640
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest current issue with validation is that Validation is done on each models one by one with no relations.
So if we have a model with a property that is another model, we won't keep the path to the validated properties in that sub-model.
The idea is to use one native Compound Constraint for each model, then to use theses constraints to validate sub-models properties.
Part 1 contains:
Part 2 will contains:
While we could wait for both part 1 & 2, I think part 1 is already a big step forward and considering the diff it makes, it's better to merge it now to avoid issues while rebasing.