[JsonSchema] Rework Validation (part2) #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korbeil
force-pushed
the
feature/rework-validation-2
branch
4 times, most recently
from
93427f4
to
7796f92
Compare
Korbeil
force-pushed
the
feature/rework-validation-2
branch
from
7796f92
to
fef982f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #640, part 2 !
We now have Constraints for all Validation rules. We need to create a Guesser that catches the objects that contains a sub-object (see
Jane\Component\JsonSchema\Guesser\Validator\Object_\SubObjectValidator) and to handle this correctly in the Constraint generation.This PR will contains: