Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Where is Udp? #13

Closed
copy opened this issue Mar 27, 2019 · 8 comments
Closed

Where is Udp? #13

copy opened this issue Mar 27, 2019 · 8 comments

Comments

@copy
Copy link

copy commented Mar 27, 2019

I can't seem to find the v0.12 version of the Udp module anywhere. The announcement mentions an Async_udp library, but it doesn't seem to be in any of Jane Stree's repositories either.
@trefis
Copy link
Contributor

trefis commented Mar 28, 2019

Indeed. Apparently the split that happened internally got reflected as a removal externally.
We'll fix that, and might also do a minor release of v0.12.

@Leonidas-from-XIV
Copy link

I ran across the same today. @trefis, is there any update on this? So far this is what is keeping us on v0.11. I saw some packages already got a v0.12.1 refresh.

@trefis
Copy link
Contributor

trefis commented May 10, 2019

Sorry for the delay.
There will be a minor release "soon" to add 4.08 support to our packages that miss it. We will release async_extra (with async_udp) at that time.

@xclerc
Copy link
Contributor

xclerc commented May 27, 2019

We are about to release a new version of async_extra,
we only need a new release of ppxlib (review being in
progress).

@mbacarella
Copy link

I guess this didn't happen? Is v0.12 just going to be missing Async Udp?

As a workaround I just copy/pasted async_udp.ml (and import.ml) from async_extra.v0.11 into my project in the meantime so no rush I guess. It's probably not violating Jane Street's IP or anything. 🙄

@Leonidas-from-XIV
Copy link

@mbacarella Maybe you could make this into an OPAM package? That way it would make v0.12 usable for people that need UDP?

@mbacarella
Copy link

@Leonidas-from-XIV that's not nearly as illegal, but okay.

See README at https://github.com/mbacarella/async_udp

Basically has instructions on how to opam pin the repo.

Let me know how it goes.

@Leonidas-from-XIV Leonidas-from-XIV mentioned this issue Oct 25, 2019
Closed
@xclerc xclerc mentioned this issue Oct 25, 2019
Merged
brendanlong added a commit to arenadotio/ocaml-statsd-client that referenced this issue Nov 7, 2019
@brendanlong
Add a dependency on async_udp
81c8079 
This is necessary for Async v0.12:

janestreet/async_extra#13
ocaml/opam-repository#15114
brendanlong added a commit to arenadotio/ocaml-statsd-client that referenced this issue Nov 7, 2019
@brendanlong
Add a dependency on async_udp
b6f0f67 
This is necessary for Async v0.12:

janestreet/async_extra#13
ocaml/opam-repository#15114
@copy
Copy link
Author

copy commented Nov 13, 2019

Closing this since Async_udp has been released as a stand-alone project: ocaml/opam-repository#15114

@copy copy closed this as completed Nov 13, 2019
@brendanlong brendanlong mentioned this issue Nov 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@trefis @Leonidas-from-XIV @mbacarella @xclerc @copy