Solaris 11/OpenIndiana building patch #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #define LOCK_NB 4 /* don't block when locking */ | ||
| #define LOCK_UN 8 /* unlock */ | ||
|
|
||
| /* flock wrapper for solaris 11/openindiana by Jonathan Perkin */ |
There was a problem hiding this comment.
is this original code or from some other source that needs a license?
There was a problem hiding this comment.
it's taken from this blog post http://www.perkin.org.uk/posts/solaris-portability-flock.html I think we need to contact the author, but i don't think he wouldn't mind including it as he wishes for this code to be included in illumos
|
I'm closing this one because too many things changed since this PR was created. Feel free to create updated new ones if still necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes core compile on Solaris 11/OpenIndiana, it's not the best way as it detects the platform by using __sun macro definition which is obviously present only on Solaris-based operating systems. However this can further be improved. I hope you'll find it useful and will take steps to implement support for this less popular platform