Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an go example that actually works #98

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Add an go example that actually works #98

merged 1 commit into from
Mar 30, 2022

Conversation

cgaebel
Copy link
Contributor

@cgaebel cgaebel commented Mar 30, 2022

Go code is still a little broken because it has custom control flow when it switches stacks. We'll fix that one day, but not today.

Screen Shot 2022-03-29 at 10 54 26 PM

@cgaebel
Add an go example that actually works
779d8b4 
Go code is still a little broken because it has custom control flow when
it switches stacks. We'll fix that one day, but not today.
@cgaebel cgaebel requested a review from Xyene March 30, 2022 02:56
@cgaebel cgaebel mentioned this pull request Mar 30, 2022
Open
Xyene
Xyene approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cgaebel cgaebel merged commit ca44908 into janestreet:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xyene Xyene Xyene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cgaebel @Xyene