Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read_cma #9

Merged
merged 1 commit into from Sep 19, 2023
Merged

Fix read_cma #9

merged 1 commit into from Sep 19, 2023

Conversation

art-w
Copy link
Contributor

@art-w art-w commented Jul 4, 2023

A quick fix to compile ppxlib with the ocaml trunk, as the Cmo_format.cu_name is now a newtype since ocaml/ocaml#12031

https://github.com/ocaml/ocaml/blob/7810957dec3137ad386bd529c32e61659102398c/file_formats/cmo_format.mli#L20-L21

@ccasin ccasin merged commit a10fbe0 into janestreet:master Sep 19, 2023
1 check failed
@hhugo
Copy link

hhugo commented Jan 3, 2024

Can we have a new opam release with ocaml 5.2 support ? I'm surprised this was merged without some sort of conditional compilation to support OCaml version < 5.2

@ccasin
Copy link
Contributor

ccasin commented Jan 3, 2024

Can we have a new opam release with ocaml 5.2 support ? I'm surprised this was merged without some sort of conditional compilation to support OCaml version < 5.2

I believe @dkalinichenko-js is working on a new release of our libraries, but I do not know if it supports ocaml 5.2.

@hhugo
Copy link

hhugo commented Jan 3, 2024

The last release of ocaml-compiler-libs is 3 years old, I'm not sure it is released like other packages.
The master branch works fine with ocaml 5.2 (thanks to this PR) but won't work on older ocaml compilers.

@art-w
Copy link
Contributor Author

art-w commented Jan 3, 2024

Yeah hm, considering that ocaml-compiler-libs had been very stable until now, I felt it would be simple enough to let the opam solver choose which version of this package is compatible with the current switch. Do you need to set a hard version on ocaml-compiler-libs or do you plan to add new features? (the opam bound isn't future proof, I can add some conditional compilation if preferred)

@dkalinichenko-js
Copy link

I've submitted a PR with a new release v0.17.0 for 5.2 and above here. I think this is sufficient for the opam solver to choose the right version. We don't really plan to add new features to this library, so there's no need for conditional compilation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants