Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package ocaml-compiler-libs.v0.17.0 #25029

Merged

Conversation

public-release
Copy link

ocaml-compiler-libs.v0.17.0

OCaml compiler libraries repackaged
This packages exposes the OCaml compiler libraries repackages under
the toplevel names Ocaml_common, Ocaml_bytecomp, Ocaml_optcomp, ...



馃惈 Pull-request generated by opam-publish v2.3.0

@dkalinichenko-js
Copy link
Contributor

Ah, there's no CI for OCaml 5.2 yet. @hhugo should we still release this package version before OCaml 5.2 is out? I understand ppxlib on 5.2 depends on this.

@hhugo
Copy link
Contributor

hhugo commented Jan 4, 2024

With this release, one just need to pin ppxlib to the right version. So I'm in favor.for such release. Maybe one should add an upper bound on the ocaml version to older release of ocaml-compiler-libs.

@kit-ty-kate what do you think ?

@kit-ty-kate
Copy link
Member

@hhugo i was waiting for the first alpha to look at the failures on 5.2 properly but yes it seems that all previous versions of ocaml-compiler-libs are incompatible with 5.2 so an upper-bound should be added indeed.

As for CI, I鈥檓 not responsible for that or for opam-repository maintainance anymore but i encourage you to open a ticket in https://github.com/ocaml/infrastructure/issues to ask that 5.2 be added to the test matrix. However in the meantime a manual check by the opam-repository maintainers should suffice (even more as 5.2 is not released yet)

@mseri
Copy link
Member

mseri commented Jan 24, 2024

@dkalinichenko-js is it possible to add the upper bounds either here (or in a separate PR)? I'd like to merge that when merging this

@dkalinichenko-js
Copy link
Contributor

@mseri ping

@mseri
Copy link
Member

mseri commented Feb 1, 2024

Oh, thanks a lot! I had missed the new commit!

@mseri mseri merged commit a66ef6f into ocaml:master Feb 1, 2024
1 of 2 checks passed
@hhugo
Copy link
Contributor

hhugo commented Feb 1, 2024

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants