Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some detail to signal docstring #1506

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

sogaiu
Copy link
Contributor

@sogaiu sogaiu commented Sep 17, 2024

This PR is part of the effort to address this issue. The other part of the effort has been submitted in this PR.

This PR is mostly about adding some detail to signal's docstring.

As a related set of changes, there are a couple of "reminders" that have been added to util.c (before janet_signal_names and janet_status_names) to help keep things in sync in the event of changes.

Copy link
Member

@pepe pepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bakpakin bakpakin merged commit ee90f9d into janet-lang:master Sep 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants