Update check for existing table #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change in sqlalchemy 1.4 changed how to check whether a table exists. This enables the new check and the old check, tested on sqlalchemy 1.3 and 1.4. Co-authored-by: Jordi Aranda <jarandaf@users.noreply.github.com>
Newer versions of mypy complain when named tuple is passed the wrong name. Also added types-cachetools as a test dependency to ensure mypy checks pass.
|
@jarandaf - this should fix the issue you were seeing. I added you as a co-author to the commit, to make sure you get credit for finding the fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in sqlalchemy 1.4 changed how to check whether a table exists. This enables the new check and the old check, tested on sqlalchemy 1.3 and 1.4.
This fixes #69
Co-authored-by: Jordi Aranda jarandaf@users.noreply.github.com