New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettify #253
Merged
Merged
Prettify #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgdavid
force-pushed
the
feature/prettify
branch
from
June 30, 2019 15:52
890196e
to
5aed29d
Compare
Also includes .prettierignore
To disable rules that conflict with Prettier. https://prettier.io/docs/en/integrating-with-linters.html#eslint Also includes .eslintignore
dgdavid
force-pushed
the
feature/prettify
branch
from
June 30, 2019 16:01
5aed29d
to
9c8337f
Compare
imobachgs
approved these changes
Jul 1, 2019
dgdavid
added a commit
that referenced
this pull request
Feb 7, 2020
Also removes the precise-commits[1] package which is no longer necessary according to the migration guide for lint-staged v10[2]. Related to #253. [1] https://github.com/nrwl/precise-commits [2] https://github.com/okonet/lint-staged#v10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does basically
fourfive things (related in some way):updates the entire codebase written during the HackWeek to have the same code style (using Prettier and Stylelint)
adjust a bit more the rules and configuration used for that purpose
fixes present copyright headers
adds missing copyright headers
reintroduces the LICENSE.txt file
Regarding the common code style, there are a few choices that I do not like either. But, if I understood correctly, we did not want to waste time discussing or reaching agreements about what we prefer. That's the reason why I introduced Prettier (now with a couple of rules tuning).
I also added a pre-commit hook and a combination of tools (lint-staged and precise-commits) with the intention to
In other words, to format automatically the stated coded (precise-commit) and add the changes to the same commit (lint-staged).
That way,
But something went wrong and this goodwill turned in small headaches (#243, #248, #249). Sorry guys! 馃槄
However, the hook is still there (now also fixing automatically the CSS 馃檮), because I think the mentioned headaches were because a mistake in the configuration. Nevertheless, we need to discuss if we will keep the hook as it is (fixing things silently) or change it to abort the commit.
And... THAT'S ALL! 馃槣