When admin config is missing in Databases, now is copied from write c…

…onfig

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [5.4.5] - 2023-03-14
+### Changed
+- **Client Creation**. When `admin` config is missing on Databases, the config is now copied from `write`
+
 ## [5.4.4] - 2023-01-09
 ### Fixed
 - Client `ListenerRemoved` fixed response

lib/helpers/client-formatter.js

@@ -93,6 +93,9 @@ module.exports = class ClientFormatter {
 				if(!dbKeyConfig.write)
 					dbKeyConfig = { write: dbKeyConfig };
 
+				if(!dbKeyConfig.admin)
+					dbKeyConfig.admin = dbKeyConfig.write;
+
 				this.settings[dbKey] = dbKeyConfig;
 
 				Object.values(dbKeyConfig)

lib/helpers/credentials-fetcher.js

@@ -12,7 +12,9 @@ module.exports = class CredentialsFetcher {
 		return this.secretValue
 			&& this.secretValue.databases
 			&& this.secretValue.databases[key]
-			&& this.secretValue.databases[key][accessType];
+			&& this.secretValue.databases[key][accessType]
+			? this.secretValue.databases[key][accessType]
+			: {}; // devuleve un obj vacio porque del otro lado se hace un spread
 	}
 
 	static async fetch() {

tests/api-create.js

@@ -167,11 +167,8 @@ describe('Client Create API', () => {
 					stubGetSecret(sinon, {
 						databases: {
 							secureDB: {
-								write: {
-									host: 'secure-host',
-									user: 'secure-user',
-									password: 'secure-password'
-								}
+								write: { host: 'secure-host', user: 'secure-user', password: 'secure-password' },
+								admin: { host: 'secure-host', user: 'secure-user', password: 'secure-password' }
 							}
 						}
 					});

tests/helpers/prepare-fake-client.js

@@ -11,13 +11,24 @@ module.exports = (code, addSecureData = false, addDB = true) => ({
 				host: 'database-host',
 				database: `janis-${code}`,
 				someLimit: 10
+			},
+			admin: {
+				skipFetchCredentials: true,
+				host: 'database-host',
+				database: `janis-${code}`,
+				someLimit: 10
 			}
 		},
 		onlyWriteDB: {
 			write: {
 				skipFetchCredentials: true,
 				host: 'write-database-host',
 				database: `janis-write-${code}`
+			},
+			admin: {
+				skipFetchCredentials: true,
+				host: 'write-database-host',
+				database: `janis-write-${code}`
 			}
 		},
 		completeDB: {
@@ -30,6 +41,11 @@ module.exports = (code, addSecureData = false, addDB = true) => ({
 				skipFetchCredentials: true,
 				host: 'complete-read-database-host',
 				database: `janis-complete-read-${code}`
+			},
+			admin: {
+				skipFetchCredentials: true,
+				host: 'complete-write-database-host',
+				database: `janis-complete-write-${code}`
 			}
 		},
 		secureDB: {
@@ -40,6 +56,14 @@ module.exports = (code, addSecureData = false, addDB = true) => ({
 					user: 'secure-user',
 					password: 'secure-password'
 				}
+			},
+			admin: {
+				database: `secure-${code}`,
+				...addSecureData && {
+					host: 'secure-host',
+					user: 'secure-user',
+					password: 'secure-password'
+				}
 			}
 		}
 	} : {},

tests/listener-created.js

@@ -403,11 +403,8 @@ describe('Client Created Listener', async () => {
 				stubGetSecret(sinon, {
 					databases: {
 						secureDB: {
-							write: {
-								host: 'secure-host',
-								user: 'secure-user',
-								password: 'secure-password'
-							}
+							write: { host: 'secure-host', user: 'secure-user', password: 'secure-password' },
+							admin: { host: 'secure-host', user: 'secure-user', password: 'secure-password' }
 						}
 					}
 				});