Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make better use of existing shiny classes #20

Open
jankowtf opened this issue Oct 27, 2014 · 0 comments
Open

Make better use of existing shiny classes #20

jankowtf opened this issue Oct 27, 2014 · 0 comments

Comments

@jankowtf
Copy link
Owner

Better understand the interaction between the classes shiny::ReactiveValues, shiny::Observable and shiny::Context with respect to invalidation (fields .invalidated and associated functions).

As currently only a modified version of shiny::Observable is used, there still needs to be this manual distinction to be made in setShinyReactive():

if (o$.invalidated) {
  out <- o$getValue()
} else {
  out <- o$.updateValue()
}

This feels wrong and might also lead to inconsistencies when trying to integrate reactive objects set by setShinyReactive() in the shiny workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant