Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cover/shade support #21

Merged
merged 3 commits into from
Jun 8, 2023
Merged

Fix cover/shade support #21

merged 3 commits into from
Jun 8, 2023

Conversation

alexbrasetvik
Copy link
Contributor

I've only tested this with 2023.5.x, and this would be my first stab at anything homeassistant.

Depending on jankrib/xcomfort-python#11, this works with all my shades, including setting a direct position.

@eliasdjup
Copy link
Contributor

eliasdjup commented Jun 7, 2023

Hi @alexbrasetvik,

Firstly, thank you for your efforts in testing and working on this update. It sounds promising, especially if it's compatible with setting a direct position for all shades.

However, I'm a bit unsure of how to proceed with testing this myself. I'm currently using HAOS and HACS and would appreciate some guidance on how to install the dependency jankrib/xcomfort-python#11.

I tried cloning https://github.com/jankrib/xcomfort-python/ repo and checkout alexbrasetvik:fix-shades branch in the HA terminal. But I am unable to run pip install . there.

Any help on the installation would be highly appreciated!

@alexbrasetvik
Copy link
Contributor Author

alexbrasetvik commented Jun 7, 2023

@eliasdjup I'm a homeassistant beginner myself, and not familiar with with HAOS or HACS, but this was my way of manually getting it going:

  • From this repo, ha-xcomfort-bridge/custom_components/xcomfort_bridge needs to go into /path/to/home-assistant/custom_components. You probably have the existing version in there already.
  • You probably also have the existing version of the xcomfort library from the other repo. I removed the dependency on this library from manifest.json so it doesn't try to reinstall or fail to install the yet-to-be-released version, then dropped my changes into /usr/local/lib/python3.10/site-packages/xcomfort/. If that's some other path for you, run python -c 'import xcomfort; print(xcomfort.__file__)' to find where.

There might be less blunt and better ways of doing it with HAOS, but this got me going at least. :)

@jankrib jankrib merged commit ecb18f5 into jankrib:master Jun 8, 2023
@eliasdjup
Copy link
Contributor

@alexbrasetvik This worked brilliantly. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants