Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thanks for the great work, @jankrib :)
I have two different kinds of shades. Both types would react to the
move_down
operation, but not the two other operations, where I found the state constants sent to differ from those that the public app makes.Some of my shades support setting a direct position, e.g. 50%, while some of the other shades do not. I think the logic for detecting this should be right, but hard to tell through reverse engineering and guessing :)
@jankrib Does the existing code move shades correctly for you? If so we'll need to detect differences in components/state somehow so my changes do not break things.
Here's the raw component data I get on an awning shade not supporting setting a direct position:
This one does support setting a position, e.g. 50% closed: