Fix bug in AnimatedFurnitureVisualization

jankuss · Jan 23, 2021 · 58775a5 · 58775a5
1 parent fff3b27
commit 58775a5
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/src/objects/furniture/BaseFurniture.tsx b/src/objects/furniture/BaseFurniture.tsx
@@ -305,8 +305,11 @@ export class BaseFurniture implements IFurnitureEventHandlers {
 
   public set animation(value) {
     this._animation = value;
-    this.visualization.updateAnimation(this.animation);
-    this._handleAnimationChange();
+
+    if (this.mounted) {
+      this.visualization.updateAnimation(this.animation);
+      this._handleAnimationChange();
+    }
   }
 
   public get maskId() {
@@ -344,6 +347,8 @@ export class BaseFurniture implements IFurnitureEventHandlers {
   };
 
   private _updateDirection() {
+    if (!this.mounted) return;
+
     if (this._validDirections != null) {
       this.visualization.updateDirection(
         getDirectionForFurniture(this.direction, this._validDirections)

diff --git a/storybook/stories/Furniture.stories.ts b/storybook/stories/Furniture.stories.ts
@@ -110,6 +110,16 @@ export function Animated() {
         }
       };
 
+      if (i === 0) {
+        room.onActiveTileChange.subscribe((value) => {
+          if (value == null) return;
+
+          furniture.roomX = value.roomX;
+          furniture.roomY = value.roomY;
+          furniture.roomZ = value.roomZ;
+        });
+      }
+
       room.addRoomObject(furniture);
     }
 

diff --git a/storybook/stories/Issues.stories.ts b/storybook/stories/Issues.stories.ts
@@ -207,6 +207,8 @@ export function IssueWithAvatarEventsNotHandled() {
 
     avatar.onDoubleClick = (event) => {
       event.stopPropagation();
+
+      action("Avatar Double Clicked")(event);
     };
 
     furniture.onClick = (event) => {