Add no-shadow eslint rule

janpaul123 · Feb 13, 2018 · 60a8226 · 60a8226
1 parent 1ad62c2
commit 60a8226
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -8,6 +8,8 @@ module.exports = {
     // Per https://stackoverflow.com/a/46809082
     'react/jsx-uses-react': 'error',
     'react/jsx-uses-vars': 'error',
+
+    'no-shadow': 'error',
   },
   env: {
     browser: true,

diff --git a/client/camera/CameraVideo.js b/client/camera/CameraVideo.js
@@ -124,9 +124,9 @@ export default class CameraVideo extends React.Component {
                 key={position}
                 x={point.x * width}
                 y={point.y * height}
-                onChange={point => {
+                onChange={newPoint => {
                   const knobPoints = this.props.config.knobPoints.slice();
-                  knobPoints[position] = { x: point.x / width, y: point.y / height };
+                  knobPoints[position] = { x: newPoint.x / width, y: newPoint.y / height };
                   this.props.onConfigChange({ ...this.props.config, knobPoints });
                 }}
               />