Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add CODEOWNERS #145

Merged
merged 1 commit into from
Aug 20, 2019
Merged

github: add CODEOWNERS #145

merged 1 commit into from
Aug 20, 2019

Conversation

alexandrevicenzi
Copy link
Collaborator

CODEOWNERS will automatically invite members
for code review.

With branch protection at least one code owner
must approve a PR before it's merged.

CODEOWNERS will automatically invite members
for code review.

With branch protection at least one code owner
must approve a PR before it's merged.
@alexandrevicenzi
Copy link
Collaborator Author

@jantic Let me know your thoughts on this.

I do use this a lot, it's helpful for those who send PRs because they usually don't know who to request for review.

Copy link
Owner

@jantic jantic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. If you're up for being requested to do reviews go for it!

@jantic jantic merged commit 1c38c47 into jantic:master Aug 20, 2019
@alexandrevicenzi alexandrevicenzi deleted the codeowners branch August 20, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants