Version 3.0 #558

jantimon · 2017-01-23T22:59:19Z

At all contributors
@SpaceK33z, @SimenB, @numical, @kennyt, @okhomenko, @cgreening, @anjianshi, @mistadikay, @mc-zone, @JSteunou, @spuf, @vincentngthu, @NekR, @mateatslc, @chiplay, @ascariandrea, @graingert, @zzuieliyaoli, @foglerek, @sandeep45, @koenpunt, @sokra, @shprink, @cesarandreu, @oliviertassinari, @sebastienbarre, @jamesjieye, @AndrewRayCode, @kurtharriger, @ai, @PeachScript, @kinday, @TalAter, @chrillo, @timoxley, @insin, @adjohnson916, @Madalosso, @mgol, @victorwpbastos, @pburtchaell, @dtinth, @yyx990803, @michael-wolfenden, @denis-sokolov, @jirikolarik, @jpetitcolas, @ruehl, @Foxandxss, @creeperyang, @vyorkin, @thomasguillory, @tlrobinson, @nartamonov

I am planning to move the webpack-html-plugin forward to 3.0 and would like to gather your input which (breaking-)changes you would like to see

Planed changes:

Use stats.entrypoints to determine which links/scripts should be added to the html. (Unfortunately this will stop the support for webpack 1 as @sokra won't port this feature back into webpack 1)
Finally jump up some node versions to node 4 (the official supported version for webpack 2)
Remove type: 'text/javascript'
Remove html minifcation (could still be done by a plugin if needed)
Remove chunksSortMode (as stats.entrypoints are already sorted)

Open for discussion:

Switch to ava
Generate multiple html files (e.g. by using [name] as output name)

The text was updated successfully, but these errors were encountered:

graingert · 2017-01-23T23:00:42Z

these changes won't break my build.

SpaceK33z · 2017-01-23T23:18:02Z

Sounds like good changes, I agree with all of them 👍 . Let me know if you need any help with the changes, I might have some time next week.

victorwpbastos · 2017-01-23T23:20:02Z

Better favicon support would be fantastic. Em 23 de jan de 2017 21:18, "Kees Kluskens" <notifications@github.com> escreveu: Sounds like good changes, I agree with all of them 👍 . Let me know if you need any help with the changes, I maybe have some time next week. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#558 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA-GqyHWGP4TigN3aTscvycEko19Ol5Oks5rVTUsgaJpZM4Lrp6G> .

TheLarkInn · 2017-01-23T23:30:24Z

Would you consider discussion around migrating repo to github.com/webpack-contrib org?

pburtchaell · 2017-01-24T01:43:34Z

None of the changes will affect me. 👍

Remove type: 'text/javascript

This was added via #311 (original issue: #309). As it turns out, the issue I originally reported was caused by the font-feature-settings CSS property. If you use that property on Safari, it breaks the page entirely. So, unless there was another reason why this was added, I think we can remove it.

vincent-ng · 2017-01-24T03:15:47Z

I'm looking forward to the feature of generating multiple html files. 👍

creeperyang · 2017-01-24T04:20:23Z

Generate multiple html files is a good feature!

Include it with v3 😄

NekR · 2017-01-24T05:02:45Z

You know that you can generate multi html files by using multiple instances of HtmlWebpackPlugin, right?

creeperyang · 2017-01-24T05:53:03Z

Sure. I think it's not elegant if you using ten instances for ten pages. (Although you can use something like Array.map). Support multiple pages with one instance is great.

SimenB · 2017-01-24T06:19:04Z

Only thing there that I'd need to make changes for is minifying, and I wholly support making a separate plugin for it. So 👍 from me! 😄
A change you could consider is dropping Bluebird for native promises. That would break my plugin (http://npm.im/add-asset-html-webpack-plugin), but I can just wrap it in Bluebird on my side (as I need the ordered iteration it provides).

mc-zone · 2017-01-24T07:51:04Z

How about isomorphic support?

I've been looking for an elegant solution about template reusability when I use server-rendering.

Like the following (A rough example):

A common template :

template.ejs

<!DOCTYPE html>
<html lang="en">
<head>
  <title><%= htmlWebpackPlugin.options.title %></title>
</head>
<body>
  
<!-- Use a special format to pass server-rendering data? -->
<!--{{ serverRenderingData.body }} --> 

<script src="<%= htmlWebpackPlugin.files.chunks.app.entry %>"></script>
</body>
</html>

2(kinds of) files are generated :

template.html (HTML file)

<!DOCTYPE html>
<html lang="en">
<head>
  <title>title</title>
</head>
<body>
  

<script src="//example.com/publicPath/app.bundle.js"></script>
</body>
</html>

template.js (CommonJS module to be required on Node)**

module.exports = function(serverRenderingData){
  return `
    <!DOCTYPE html>
    <html lang="en">
    <head>
      <title>title</title>
    </head>
    <body>
      
    ${serverRenderingData.body}

    <script src="//example.com/publicPath/app.bundle.js"></script>
    </body>
    </html>
  `
};

Anyone has better practice? or any suggestion?

JSteunou · 2017-01-24T11:51:49Z

I'm 👍 with all those changes as you are following semver so the impact can be managed easily. Thank you for including us in the discussion!

spuf · 2017-01-24T21:45:00Z

Switch to ava

jest?

jantimon · 2017-01-25T08:17:09Z

thanks for all your feedback 👍

@spuf ava has build in support for async even for node 4 - any reasons to use jest instead?
@mc-zone this is already possible (in a way) since 2.0 - feel free to open a issue / stack overflow question
@SimenB yes - I guess it would be appropriate to drop bluebird
@TheLarkInn open for a discussion in slack
@SpaceK33z thanks - help is always appreciated

graingert · 2017-01-27T12:43:04Z

@TheLarkInn probably a separate topic to V3.0: #565

numical · 2017-01-29T11:59:47Z

Hi, if you choose to support multiple html files, can you ensure your events API supports this - don't know what mechanism you will choose but, e.g., ensure you pass through the entry point for that html file.
(To be honest, the current approach where you have a separate instance for each page might appear clunky but actually works quite well alongside separate instances of related plugins such as ExtractText etc).

jantimon · 2017-01-29T22:59:41Z

@numical I'll try to keep it in my mind ;)

darylteo · 2017-02-01T03:08:23Z

WRT generating multiple files: I'm working with a static site generator (metalsmith) and using html-webpack-plugin to generate injected assets. However, because pages can be added or removed at "devtime", the plugin does not pick up these new files, requiring a full rebuild just to pick up the new file.

Not sure what can be done here, but just chipping in. A single instance of the plugin that takes a glob and watches for changes may justify it as an enhancement.

Disorrder · 2017-02-21T18:16:41Z

+1 waiting for entrypoints and several files. Good for building multipage applications!

TheLarkInn · 2017-02-21T21:35:59Z

If you are looking for a workaround for the whole multipage I have something that wraps this plugin github.com/mutualofomaha/multipage-webpack-plugin that might help

airtonix · 2017-03-16T07:58:05Z

removing chunkSortMode is generally going to be a BadIdea(tm). stats.entrypoints is rarely in the order some people may want... I know it definitely won't be in my case.

I'm currently having to use this snippet to make sure my bits are properly sorted: #481 (comment)

var-bp · 2017-05-11T06:55:49Z

please make dynamic entrypoints, for example:

const path = require('path');
const glob = require('glob');
const HtmlWebpackPlugin = require('html-webpack-plugin');

const config = {};

glob.sync(`${basePath}/src/layouts/*.?(pug|jade)`).forEach((item) => {
  config.plugins.push(
    new HtmlWebpackPlugin({
      filename: `${path.basename(item, path.extname(item))}.html`,
      template: item
    })
});

module.exports = config;

princemaple · 2018-03-01T21:02:28Z

Hi @jantimon will these be addressed soon? Now that 3.0 is out.

Benno007 · 2018-04-19T01:49:52Z

Might be a good idea to remove chunkSortMode as an option from the documentation for version 3?

edmorley · 2018-07-05T15:15:23Z

Remove html minifcation (could still be done by a plugin if needed)

Is this going to be done for v4?

jantimon · 2018-09-11T07:34:28Z

Because of the webpack 4 release those changes were postponed to html-webpack-plugin 4

Almost all features described above are implemented in #953

And are already published as alpha to npm:

https://www.npmjs.com/package/html-webpack-plugin/v/4.0.0-alpha.2

lock · 2018-10-11T08:05:14Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

This was referenced Jan 29, 2017

[v3] Remove text/javascript from all script tags #572

Closed

[v3] Remove html minification #573

Closed

Simplify script and meta tags #522

Closed

jantimon mentioned this issue Jan 29, 2017

Version 3.x #575

Closed

clydin mentioned this issue Jun 6, 2017

Add support for minifying index.html angular/angular-cli#5753

Merged

Repository owner deleted a comment from tkrotoff Jul 7, 2017

mastilver mentioned this issue Sep 10, 2017

Improve perf by cacheing chunks? #780

Closed

edmorley mentioned this issue Aug 28, 2018

Decide what to do with the HTML minification feature #1036

Closed

jantimon closed this as completed Sep 11, 2018

lock bot locked as resolved and limited conversation to collaborators Oct 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Version 3.0 #558

Version 3.0 #558

jantimon commented Jan 23, 2017 •

edited

graingert commented Jan 23, 2017

SpaceK33z commented Jan 23, 2017 •

edited

victorwpbastos commented Jan 23, 2017 via email

TheLarkInn commented Jan 23, 2017

pburtchaell commented Jan 24, 2017 •

edited

vincent-ng commented Jan 24, 2017

creeperyang commented Jan 24, 2017

NekR commented Jan 24, 2017

creeperyang commented Jan 24, 2017

SimenB commented Jan 24, 2017 •

edited

mc-zone commented Jan 24, 2017 •

edited

JSteunou commented Jan 24, 2017

spuf commented Jan 24, 2017

jantimon commented Jan 25, 2017

graingert commented Jan 27, 2017

numical commented Jan 29, 2017

jantimon commented Jan 29, 2017

darylteo commented Feb 1, 2017 •

edited

Disorrder commented Feb 21, 2017

TheLarkInn commented Feb 21, 2017

airtonix commented Mar 16, 2017

var-bp commented May 11, 2017 •

edited

princemaple commented Mar 1, 2018

Benno007 commented Apr 19, 2018

edmorley commented Jul 5, 2018

jantimon commented Sep 11, 2018

lock bot commented Oct 11, 2018

Version 3.0 #558

Version 3.0 #558

Comments

jantimon commented Jan 23, 2017 • edited

graingert commented Jan 23, 2017

SpaceK33z commented Jan 23, 2017 • edited

victorwpbastos commented Jan 23, 2017 via email

TheLarkInn commented Jan 23, 2017

pburtchaell commented Jan 24, 2017 • edited

vincent-ng commented Jan 24, 2017

creeperyang commented Jan 24, 2017

NekR commented Jan 24, 2017

creeperyang commented Jan 24, 2017

SimenB commented Jan 24, 2017 • edited

mc-zone commented Jan 24, 2017 • edited

Like the following (A rough example):

JSteunou commented Jan 24, 2017

spuf commented Jan 24, 2017

jantimon commented Jan 25, 2017

graingert commented Jan 27, 2017

numical commented Jan 29, 2017

jantimon commented Jan 29, 2017

darylteo commented Feb 1, 2017 • edited

Disorrder commented Feb 21, 2017

TheLarkInn commented Feb 21, 2017

airtonix commented Mar 16, 2017

var-bp commented May 11, 2017 • edited

princemaple commented Mar 1, 2018

Benno007 commented Apr 19, 2018

edmorley commented Jul 5, 2018

jantimon commented Sep 11, 2018

lock bot commented Oct 11, 2018

jantimon commented Jan 23, 2017 •

edited

SpaceK33z commented Jan 23, 2017 •

edited

pburtchaell commented Jan 24, 2017 •

edited

SimenB commented Jan 24, 2017 •

edited

mc-zone commented Jan 24, 2017 •

edited

darylteo commented Feb 1, 2017 •

edited

var-bp commented May 11, 2017 •

edited