Error in 2.30.0 - ERROR in Template execution failed: TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined

[billneff79]

After upgrading from 2.29.0 to 2.30.0 this morning, we are seeing this error in our build. This does not occur in 2.29.0. Was there supposed to be a breaking change in 2.30.0?

ERROR in Template execution failed: TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined

ERROR in   TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined

  - template.ejs:89 ../packages/@zimbra/webpack-config/node_modules/ejs-loader/index.js!../packages/@zimbra/webpack-config/dist/template.ejs    .module.exports
    /Users/bneff/repos/zimbra-app/packages/@zimbra/webpack-config/dist/template.ejs:89:25

  - index.js:264
    [webpack-config]/[html-webpack-plugin]/index.js:264:16

  - util.js:16 tryCatcher
    [webpack-config]/[bluebird]/js/release/util.js:16:23

  - promise.js:512 Promise._settlePromiseFromHandler
    [webpack-config]/[bluebird]/js/release/promise.js:512:31

  - promise.js:569 Promise._settlePromise
    [webpack-config]/[bluebird]/js/release/promise.js:569:18

  - promise.js:606 Promise._settlePromiseCtx
    [webpack-config]/[bluebird]/js/release/promise.js:606:10

  - async.js:138 Async._drainQueue
    [webpack-config]/[bluebird]/js/release/async.js:138:12

  - async.js:143 Async._drainQueues
    [webpack-config]/[bluebird]/js/release/async.js:143:10

  - async.js:17 Immediate.Async.drainQueues
    [webpack-config]/[bluebird]/js/release/async.js:17:14

[mastilver]

Hi @billneff79

I don't believe there is a breaking change in the new version, here's the diff if you can spot anything: 2cc10df...09a96f5

Would you mind posting your webpack config? Also can you double check it's working on 2.29.0
and it's not another dependency causing the issue?

[billneff79]

I verified that it is purely the switch from 2.29.0 to 2.30.0 that is causing it by doing the following:

npm i html-webpack-plugin@2.29.0 && npm run build # all is well
npm i html-webpack-plugin@2.30.0 && npm run build # breakage

We have a pretty complicated webpack config. I'll see if I can get it up here.

[mastilver]

@billneff79 a git repository would be even more awesome, that way I can check which commit introduced the issue :)

[ghost]

Same issue with us as well. Started happening today. We have a starter app created via preact-cli.

[mastilver]

Thank you @exp10r3r, I managed to reproduce the issue

[developit]

I may be the common denominator there, let me know if either of the templates are doing something incorrect: https://github.com/developit/preact-cli/blob/master/src/resources/template.html

[mastilver]

So this was introduced by #723 / cb15071

[mastilver]

#754 fixes the issue, I'm just waiting for @jantimon to release it and we would be good :)

[mastilver]

@developit It might be caused by this line: https://github.com/developit/preact-cli/blob/master/src/resources/template.html#L13, but I don't believe there is anything wrong with it

I will add some tests later to prevent this kind of changes to land in the future

[billneff79]

@mastilver thank you for the quick response! Much appreciated.

[jantimon]

Thanks for your quick feedback I merged #754 and released 2.30.1

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.