Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): prevent undefined error in template loader #754

Merged
merged 1 commit into from Jul 31, 2017

Conversation

mastilver
Copy link
Collaborator

closes #753

@jantimon
Copy link
Owner

Cool will release this as soon as travis is done
Do we lose the entire performance gain?
Should we add tests for that use case?

@jantimon jantimon merged commit 0cf580c into master Jul 31, 2017
@mastilver mastilver deleted the fix-template-engine-undefined-error branch July 31, 2017 14:45
@mastilver
Copy link
Collaborator Author

@jantimon We definitely need to add tests, I might have some time tonight

@jantimon
Copy link
Owner

Cool 👍

@lock
Copy link

lock bot commented May 31, 2018

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants