Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow URL or Data URI favicon #986

Closed
wants to merge 2 commits into from
Closed

Conversation

wuwb
Copy link

@wuwb wuwb commented Jun 22, 2018

feat: Allow URL or Data URI favicon.

@mastilver
Copy link
Collaborator

Did you have a look at: https://github.com/jantimon/favicons-webpack-plugin ?

@wuwb
Copy link
Author

wuwb commented Jul 1, 2018

@mastilver yes, i had looked through favicons-webpack-plugin. but in my project, i use the configs extracted from vue-route and a custom config with favicon to generate html-webpack-plugin configs, if use favicons-webpack-plugin, i have to generate a mapping favicons-webpack-plugin config to each html-webpack-plugin config, and favicons-webpack-plugin didn't providate this feature, it inject the same config to every html-webpack-plugin config.

@edmorley
Copy link
Contributor

Might another way to do this, be to have favicon use whatever webpack loader has been declared for the file type is it? ie: Then if .(ico|...) have been configured to use url-loader, the favicon will either be inlined as a data URI or as a path to the copied asset, automatically?

@edmorley
Copy link
Contributor

edmorley commented Oct 15, 2018

(That approach would also solve the "would like hash in favicon filename" use-case)

@stale
Copy link

stale bot commented Apr 13, 2019

This issue had no activity for at least half a year. It's subject to automatic issue closing if there is no activity in the next 15 days.

@stale stale bot added the wontfix label Apr 13, 2019
@stale stale bot closed this Apr 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants