-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create keyframes mock #118
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe primary change involves implementing a mock version of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
CodSpeed Performance ReportMerging #118 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/next-yak/runtime/mocks/keyframes.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/next-yak/runtime/mocks/keyframes.ts
Doesn't this mean that the dynamic tagged templates aren't correctly typed, as mocks are exposed to the outside world? |
those mocks export the public types - so they must be shipped with the correct public typings did I somehow break those types? |
Nono. I wasn't sure if you changed the types as the type signalizes that you can't use any interpolations. But I checked now and it's basically the same as the previous type so that should work :) |
this is the
keyframes
mock implementation for #56during jest/vite it's a noop because there is no css extraction compile step
Summary by CodeRabbit
keyframes
function to support testing of CSS keyframe animations.