Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rbac): fix role list view permission policies column value #1714

Merged
merged 8 commits into from
Jun 4, 2024
Merged

fix(rbac): fix role list view permission policies column value #1714

merged 8 commits into from
Jun 4, 2024

Conversation

ciiay
Copy link
Contributor

@ciiay ciiay commented May 24, 2024 •
edited
Loading

For RHIDP-2431

Screen recording

rhidp_2431.mov

Screenshot for error on fetching role conditions
image

@ciiay ciiay requested a review from a team as a code owner May 24, 2024 03:01
@ShiranHi
Copy link

@ciiay I don't see any issue here. The conditional policy is part of the original policy, functioning as an additional configuration rather than a separate condition. If the intention was to count a conditional policy separately, then we should not consider it as a new policy. In addition, we're going to improve this view to make it clearer which plugins are part of each role, so this column probably will be removed

@ciiay
Copy link
Contributor Author

ciiay commented May 28, 2024 •
edited
Loading

@ciiay I don't see any issue here.

Hi @ShiranHi , do you mean the screen recording has no issue, or the description from RHIDP-2431 has no issue? I understand they should be considered as same policy from the user's view, but implementation-wise they are retrieved separately.

If there's no issue with the current behavior I can just close this PR.

@ShiranHi
Copy link

Hey @ciiay ,It's a bit confusing, so let me clarify :)
In the Jira ticket, it appears that users see "0" in the main table list when they add a conditional policy. However, in the video attached to this PR, everything seems to be working fine. Was the screen recording added as a solution to the Jira ticket, or was it intended to showcase the problem that described in the ticket? If this is the solution - then great, it looks good

@ciiay
Copy link
Contributor Author

ciiay commented May 28, 2024 •
edited
Loading

Hi @ShiranHi , this screen recording is an evidence of the fix :) Without the fix it shows "0" after adding a conditional permission policy. But what this screen recording didn't show is, on the role Overview page, it still shows "No records found" as this fix is only focused on the role list view. Displaying the conditional permission policies on the Overview page would be a task targeting on 1.3 release. Just to confirm we are on the same page.

@ShiranHi
Copy link

Thank you @ciiay for the explanation!

divyanshiGupta
divyanshiGupta requested changes May 29, 2024
View reviewed changes
plugins/rbac/src/hooks/useRoles.ts Outdated Show resolved Hide resolved
plugins/rbac/src/hooks/useRoles.ts Outdated Show resolved Hide resolved
plugins/rbac/src/hooks/useRoles.ts Outdated Show resolved Hide resolved
plugins/rbac/src/hooks/useRoles.ts Outdated Show resolved Hide resolved
@ciiay ciiay requested a review from divyanshiGupta May 29, 2024 15:29
@ciiay ciiay force-pushed the rhidp-2431-fix-permission-policies-column-value branch from c57a822 to b83a315 Compare May 30, 2024 00:25
divyanshiGupta
divyanshiGupta requested changes May 30, 2024
View reviewed changes
plugins/rbac/src/hooks/useRoles.ts Outdated Show resolved Hide resolved
plugins/rbac/src/hooks/useRoles.ts Outdated Show resolved Hide resolved
@ciiay ciiay force-pushed the rhidp-2431-fix-permission-policies-column-value branch 2 times, most recently from ca76f7e to 76cf36e Compare May 31, 2024 01:57
divyanshiGupta
divyanshiGupta requested changes May 31, 2024
View reviewed changes
plugins/rbac/src/components/RolesList/RolesList.tsx Outdated Show resolved Hide resolved
plugins/rbac/src/hooks/useRoles.ts Outdated Show resolved Hide resolved
@ciiay ciiay force-pushed the rhidp-2431-fix-permission-policies-column-value branch from 1fa0c05 to fa31127 Compare May 31, 2024 16:24
@ciiay ciiay requested a review from divyanshiGupta May 31, 2024 17:54
divyanshiGupta
divyanshiGupta requested changes Jun 3, 2024
View reviewed changes
plugins/rbac/src/hooks/useRoles.ts Show resolved Hide resolved
plugins/rbac/src/hooks/useRoles.ts Outdated Show resolved Hide resolved
plugins/rbac/src/hooks/useRoles.ts Show resolved Hide resolved
@ciiay ciiay requested a review from divyanshiGupta June 3, 2024 13:51
ciiay added 7 commits June 3, 2024 10:32
@ciiay
fix(rbac): fix role list view permission policies column value
09e50f8 
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay
Update for review comments
2768cc4 
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay
Fixed lint issues
9df841a 
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay
Addressed comments
7396ce6 
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay
Fixed prettier issue
17c5278 
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay
Updated unit tests
43c9646 
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay
Addressed review comments
b2c3e67 
Signed-off-by: Yi Cai <yicai@redhat.com>
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.1.7 [skip ci]
fec617d 
## [1.1.7](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-argocd@1.1.6...@janus-idp/backstage-plugin-argocd@1.1.7) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.0.3 [skip ci]
6d0e933 
## [1.0.3](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-audit-log-node@1.0.2...@janus-idp/backstage-plugin-audit-log-node@1.0.3) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.0.2 [skip ci]
a587030 
## [1.0.2](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-catalog-backend-module-scaffolder-relation-processor@1.0.1...@janus-idp/backstage-plugin-catalog-backend-module-scaffolder-relation-processor@1.0.2) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.2.5 [skip ci]
60b0160 
## [1.2.5](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-dynamic-plugins-info@1.2.4...@janus-idp/backstage-plugin-dynamic-plugins-info@1.2.5) (2024-06-04)

### Features

* add method for janus-cli package metadata (simpler PR) - RHIDP-1502 ([janus-idp#1753](janus-idp#1753)) ([b81a849](janus-idp@b81a849))
* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add proper empty page for RBAC plugin ([janus-idp#1728](janus-idp#1728)) ([79e62a6](janus-idp@79e62a6))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.4.10 [skip ci]
6e7ae1c 
## [1.4.10](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-jfrog-artifactory@1.4.9...@janus-idp/backstage-plugin-jfrog-artifactory@1.4.10) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.9.11 [skip ci]
7c1f74c 
## [1.9.11](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-keycloak-backend@1.9.10...@janus-idp/backstage-plugin-keycloak-backend@1.9.11) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.10.20 [skip ci]
43efa34 
## [1.10.20](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-kiali-backend@1.10.19...@janus-idp/backstage-plugin-kiali-backend@1.10.20) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.4.12 [skip ci]
ac9f273 
## [1.4.12](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-scaffolder-backend-module-kubernetes@1.4.11...@janus-idp/backstage-scaffolder-backend-module-kubernetes@1.4.12) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.6.9 [skip ci]
e9a563c 
## [1.6.9](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-nexus-repository-manager@1.6.8...@janus-idp/backstage-plugin-nexus-repository-manager@1.6.9) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.3.6 [skip ci]
cbb96ce 
## [1.3.6](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/plugin-notifications@1.3.5...@janus-idp/plugin-notifications@1.3.6) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.4.17 [skip ci]
d92df82 
## [1.4.17](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/plugin-notifications-backend@1.4.16...@janus-idp/plugin-notifications-backend@1.4.17) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 4.1.7 [skip ci]
d23777c 
## [4.1.7](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-ocm@4.1.6...@janus-idp/backstage-plugin-ocm@4.1.7) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 4.0.7 [skip ci]
ac493ca 
## [4.0.7](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-ocm-backend@4.0.6...@janus-idp/backstage-plugin-ocm-backend@4.0.7) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 3.0.2 [skip ci]
26d423e 
## [3.0.2](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-ocm-common@3.0.1...@janus-idp/backstage-plugin-ocm-common@3.0.2) (2024-06-04)

### ⚠ BREAKING CHANGES

* **rbac:** This will lead to more strict validation on the source of permission policies and roles based on the where the first role is defined.

Improves the validation of the different sources of permission policies and roles. Aims to make policy definition more consistent.

Now checks if a permission policy or role with new member matches the originating role's source and prevents any action if the sources do not match. Exception includes the event of adding
new permission policies to the RBAC Admin role defined by the configuration file. Sources include 'REST, 'CSV', 'Configuration', and 'legacy'.

Before updating, ensure that you have attempted to migrate all permission policies and roles to a single source. This can be done by checking source information through the REST API and
by querying the database. Make updates through one of the available avenues: REST API, CSV file, and the database.

To view the originating source for a particular role, query the role-metadata table or use the GET roles endpoint.

* feat(rbac): remove the ability to add permission policies to configuration role

* feat(rbac): remove no longer needed check for source in EnforcerDelegate

* feat(rbac): update yarn lock

* feat(rbac): address review comments
* **rbac:** remove token manager for auth service (janus-idp#1632)

### Features

* add custom processor module to add ScaffoldedFrom relation ([janus-idp#1591](janus-idp#1591)) ([0b36164](janus-idp@0b36164))
* add method for janus-cli package metadata (simpler PR) - RHIDP-1502 ([janus-idp#1753](janus-idp#1753)) ([b81a849](janus-idp@b81a849))
* **audit-log:** add common audit-log package ([janus-idp#1622](janus-idp#1622)) ([7e0a3dd](janus-idp@7e0a3dd))
* **deps:** use RHDH themes in the backstage app and dev pages ([janus-idp#1480](janus-idp#1480)) ([8263bf0](janus-idp@8263bf0))
* **feedback:** use backstage auth service in backend plugin ([janus-idp#1646](janus-idp#1646)) ([7d9ee11](janus-idp@7d9ee11)), closes [janus-idp#1626](janus-idp#1626)
* **orchestrator:** add permissions to orchestrator plugin ([janus-idp#1599](janus-idp#1599)) ([d0a4531](janus-idp@d0a4531))
* **orchestrator:** label a Workflow assessment result as recommended ([janus-idp#1705](janus-idp#1705)) ([7e24e86](janus-idp@7e24e86))
* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))
* **rbac:** implement a file watcher for csv reloads ([janus-idp#1587](janus-idp#1587)) ([62fcafc](janus-idp@62fcafc))
* **rbac:** improve conditional policy validation ([janus-idp#1673](janus-idp#1673)) ([15dac91](janus-idp@15dac91))
* **rbac:** improve validation from source ([janus-idp#1643](janus-idp#1643)) ([5f983cb](janus-idp@5f983cb))
* **rbac:** support for updating/deleting conditional permissions ([janus-idp#1628](janus-idp#1628)) ([2bb8308](janus-idp@2bb8308))
* **topology:** add permissions to topology plugin ([janus-idp#1665](janus-idp#1665)) ([9d8f244](janus-idp@9d8f244))

### Bug Fixes

* **argocd:** make refreshInterval configuration as optional ([janus-idp#1647](janus-idp#1647)) ([2c24d35](janus-idp@2c24d35))
* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **cli:** fix entrypoint validation on backstage 1.24.0 and above. ([janus-idp#1741](janus-idp#1741)) ([6ed4171](janus-idp@6ed4171))
* **config:** enable guest provider by default ([janus-idp#1661](janus-idp#1661)) ([28ac848](janus-idp@28ac848))
* **deps:** update dependency monaco-editor to ^0.49.0 ([janus-idp#1690](janus-idp#1690)) ([34308a3](janus-idp@34308a3))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **deps:** upgrade devex plugins to mui v5 ([janus-idp#1696](janus-idp#1696)) ([06d9cf0](janus-idp@06d9cf0))
* **kiali:** removing unnecessary afterAll hook ([janus-idp#1642](janus-idp#1642)) ([a314607](janus-idp@a314607))
* **lint:** ignore lint rules on generated code ([janus-idp#1668](janus-idp#1668)) ([e375c2f](janus-idp@e375c2f))
* **orchestrator:** bump `rjsf` dependencies ([janus-idp#1715](janus-idp#1715)) ([ea31cdb](janus-idp@ea31cdb))
* **orchestrator:** export the `OrchestratorPlugin` accordingly ([janus-idp#1644](janus-idp#1644)) ([4a9d1f8](janus-idp@4a9d1f8))
* **orchestrator:** fix the common package reference version ([janus-idp#1704](janus-idp#1704)) ([942b2a3](janus-idp@942b2a3))
* **orchestrator:** fixed broken workflow viewer ([janus-idp#1717](janus-idp#1717)) ([19cc79b](janus-idp@19cc79b))
* **orchestrator:** fixes many security-related issues ([janus-idp#1681](janus-idp#1681)) ([3e801c8](janus-idp@3e801c8))
* **orchestrator:** remove the need of react dev dependencies ([janus-idp#1650](janus-idp#1650)) ([5e60875](janus-idp@5e60875))
* **orchestrator:** temporarily disable plugins/orchestrator-swf-editor-envelope build ([janus-idp#1722](janus-idp#1722)) ([5c40936](janus-idp@5c40936))
* **orchestrator:** typos mentioning OpenShift ([janus-idp#1639](janus-idp#1639)) ([7ff4c75](janus-idp@7ff4c75))
* **orchestrator:** upgrade to mui v5 ([janus-idp#1727](janus-idp#1727)) ([8b935dc](janus-idp@8b935dc))
* **quay:** remove unuseful link ([janus-idp#1692](janus-idp#1692)) ([ae27d91](janus-idp@ae27d91))
* **rbac:** add proper empty page for RBAC plugin ([janus-idp#1728](janus-idp#1728)) ([79e62a6](janus-idp@79e62a6))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** conditional access form validation ([janus-idp#1699](janus-idp#1699)) ([d56f4af](janus-idp@d56f4af))
* **rbac:** do not disable already selected rule for allOf/anyOf ([janus-idp#1739](janus-idp#1739)) ([dc73650](janus-idp@dc73650))
* **rbac:** enable save on remove-all button click ([janus-idp#1712](janus-idp#1712)) ([0502332](janus-idp@0502332))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix mui autocomplete related warnings ([janus-idp#1707](janus-idp#1707)) ([8e5c5ae](janus-idp@8e5c5ae))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
* **rbac:** fix sonar cloud issues for rbac-backend plugin ([janus-idp#1619](janus-idp#1619)) ([bf93354](janus-idp@bf93354))
* **rbac:** fix to enable create and edit role buttons on having correct permissions ([janus-idp#1703](janus-idp#1703)) ([19a9088](janus-idp@19a9088))
* **rbac:** improve criteria toggle button readability on dark themes ([janus-idp#1755](janus-idp#1755)) ([345230b](janus-idp@345230b))
* **rbac:** remove token manager for auth service ([janus-idp#1632](janus-idp#1632)) ([2f19655](janus-idp@2f19655))
* **rbac:** show configure-access cta for existing simple permission policies in edit form ([janus-idp#1702](janus-idp#1702)) ([16b7e00](janus-idp@16b7e00))
* **release:** change problematic plugins to private ([janus-idp#1738](janus-idp#1738)) ([69176bd](janus-idp@69176bd))
* **scaffolder:** update annotator action readme ([janus-idp#1638](janus-idp#1638)) ([8e3af1b](janus-idp@8e3af1b))

### Documentation

* **orchestrator:** removes instructions related to the editor ([janus-idp#1664](janus-idp#1664)) ([10a75b2](janus-idp@10a75b2))

### Other changes

* **orchestrator:** add  OrchestratorClient unit tests ([janus-idp#1640](janus-idp#1640)) ([2a2dc55](janus-idp@2a2dc55))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.5.10 [skip ci]
e5a9ba1 
## [1.5.10](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-openshift-image-registry@1.5.9...@janus-idp/backstage-plugin-openshift-image-registry@1.5.10) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.13.5 [skip ci]
ca38c9e 
## [1.13.5](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-orchestrator@1.13.4...@janus-idp/backstage-plugin-orchestrator@1.13.5) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.9.5 [skip ci]
05eb265 
## [1.9.5](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-orchestrator-backend@1.9.4...@janus-idp/backstage-plugin-orchestrator-backend@1.9.5) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.8.1 [skip ci]
725b7bd 
## [1.8.1](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-orchestrator-common@1.8.0...@janus-idp/backstage-plugin-orchestrator-common@1.8.1) (2024-06-04)

### ⚠ BREAKING CHANGES

* **rbac:** This will lead to more strict validation on the source of permission policies and roles based on the where the first role is defined.

Improves the validation of the different sources of permission policies and roles. Aims to make policy definition more consistent.

Now checks if a permission policy or role with new member matches the originating role's source and prevents any action if the sources do not match. Exception includes the event of adding
new permission policies to the RBAC Admin role defined by the configuration file. Sources include 'REST, 'CSV', 'Configuration', and 'legacy'.

Before updating, ensure that you have attempted to migrate all permission policies and roles to a single source. This can be done by checking source information through the REST API and
by querying the database. Make updates through one of the available avenues: REST API, CSV file, and the database.

To view the originating source for a particular role, query the role-metadata table or use the GET roles endpoint.

* feat(rbac): remove the ability to add permission policies to configuration role

* feat(rbac): remove no longer needed check for source in EnforcerDelegate

* feat(rbac): update yarn lock

* feat(rbac): address review comments

### Features

* add method for janus-cli package metadata (simpler PR) - RHIDP-1502 ([janus-idp#1753](janus-idp#1753)) ([b81a849](janus-idp@b81a849))
* **audit-log:** add common audit-log package ([janus-idp#1622](janus-idp#1622)) ([7e0a3dd](janus-idp@7e0a3dd))
* **orchestrator:** label a Workflow assessment result as recommended ([janus-idp#1705](janus-idp#1705)) ([7e24e86](janus-idp@7e24e86))
* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))
* **rbac:** improve conditional policy validation ([janus-idp#1673](janus-idp#1673)) ([15dac91](janus-idp@15dac91))
* **rbac:** improve validation from source ([janus-idp#1643](janus-idp#1643)) ([5f983cb](janus-idp@5f983cb))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **cli:** fix entrypoint validation on backstage 1.24.0 and above. ([janus-idp#1741](janus-idp#1741)) ([6ed4171](janus-idp@6ed4171))
* **config:** enable guest provider by default ([janus-idp#1661](janus-idp#1661)) ([28ac848](janus-idp@28ac848))
* **deps:** update dependency monaco-editor to ^0.49.0 ([janus-idp#1690](janus-idp#1690)) ([34308a3](janus-idp@34308a3))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **deps:** upgrade devex plugins to mui v5 ([janus-idp#1696](janus-idp#1696)) ([06d9cf0](janus-idp@06d9cf0))
* **orchestrator:** bump `rjsf` dependencies ([janus-idp#1715](janus-idp#1715)) ([ea31cdb](janus-idp@ea31cdb))
* **orchestrator:** fix the common package reference version ([janus-idp#1704](janus-idp#1704)) ([942b2a3](janus-idp@942b2a3))
* **orchestrator:** fixed broken workflow viewer ([janus-idp#1717](janus-idp#1717)) ([19cc79b](janus-idp@19cc79b))
* **orchestrator:** temporarily disable plugins/orchestrator-swf-editor-envelope build ([janus-idp#1722](janus-idp#1722)) ([5c40936](janus-idp@5c40936))
* **orchestrator:** upgrade to mui v5 ([janus-idp#1727](janus-idp#1727)) ([8b935dc](janus-idp@8b935dc))
* **rbac:** add proper empty page for RBAC plugin ([janus-idp#1728](janus-idp#1728)) ([79e62a6](janus-idp@79e62a6))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** conditional access form validation ([janus-idp#1699](janus-idp#1699)) ([d56f4af](janus-idp@d56f4af))
* **rbac:** do not disable already selected rule for allOf/anyOf ([janus-idp#1739](janus-idp#1739)) ([dc73650](janus-idp@dc73650))
* **rbac:** enable save on remove-all button click ([janus-idp#1712](janus-idp#1712)) ([0502332](janus-idp@0502332))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix mui autocomplete related warnings ([janus-idp#1707](janus-idp#1707)) ([8e5c5ae](janus-idp@8e5c5ae))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
* **rbac:** fix to enable create and edit role buttons on having correct permissions ([janus-idp#1703](janus-idp#1703)) ([19a9088](janus-idp@19a9088))
* **rbac:** improve criteria toggle button readability on dark themes ([janus-idp#1755](janus-idp#1755)) ([345230b](janus-idp@345230b))
* **rbac:** show configure-access cta for existing simple permission policies in edit form ([janus-idp#1702](janus-idp#1702)) ([16b7e00](janus-idp@16b7e00))
* **release:** change problematic plugins to private ([janus-idp#1738](janus-idp#1738)) ([69176bd](janus-idp@69176bd))
* **scaffolder:** update annotator action readme ([janus-idp#1638](janus-idp#1638)) ([8e3af1b](janus-idp@8e3af1b))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.7.7 [skip ci]
9f471c8 
## [1.7.7](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-quay@1.7.6...@janus-idp/backstage-plugin-quay@1.7.7) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.4.11 [skip ci]
fef5fe0 
## [1.4.11](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-scaffolder-backend-module-quay@1.4.10...@janus-idp/backstage-scaffolder-backend-module-quay@1.4.11) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.5.0 [skip ci]
7b349d2 
## [1.5.0](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-rbac-common@1.4.2...@janus-idp/backstage-plugin-rbac-common@1.5.0) (2024-06-04)

### ⚠ BREAKING CHANGES

* **rbac:** This will lead to more strict validation on the source of permission policies and roles based on the where the first role is defined.

Improves the validation of the different sources of permission policies and roles. Aims to make policy definition more consistent.

Now checks if a permission policy or role with new member matches the originating role's source and prevents any action if the sources do not match. Exception includes the event of adding
new permission policies to the RBAC Admin role defined by the configuration file. Sources include 'REST, 'CSV', 'Configuration', and 'legacy'.

Before updating, ensure that you have attempted to migrate all permission policies and roles to a single source. This can be done by checking source information through the REST API and
by querying the database. Make updates through one of the available avenues: REST API, CSV file, and the database.

To view the originating source for a particular role, query the role-metadata table or use the GET roles endpoint.

* feat(rbac): remove the ability to add permission policies to configuration role

* feat(rbac): remove no longer needed check for source in EnforcerDelegate

* feat(rbac): update yarn lock

* feat(rbac): address review comments
* **rbac:** remove token manager for auth service (janus-idp#1632)

### Features

* add custom processor module to add ScaffoldedFrom relation ([janus-idp#1591](janus-idp#1591)) ([0b36164](janus-idp@0b36164))
* add method for janus-cli package metadata (simpler PR) - RHIDP-1502 ([janus-idp#1753](janus-idp#1753)) ([b81a849](janus-idp@b81a849))
* **audit-log:** add common audit-log package ([janus-idp#1622](janus-idp#1622)) ([7e0a3dd](janus-idp@7e0a3dd))
* **deps:** use RHDH themes in the backstage app and dev pages ([janus-idp#1480](janus-idp#1480)) ([8263bf0](janus-idp@8263bf0))
* **feedback:** use backstage auth service in backend plugin ([janus-idp#1646](janus-idp#1646)) ([7d9ee11](janus-idp@7d9ee11)), closes [janus-idp#1626](janus-idp#1626)
* **orchestrator:** add permissions to orchestrator plugin ([janus-idp#1599](janus-idp#1599)) ([d0a4531](janus-idp@d0a4531))
* **orchestrator:** label a Workflow assessment result as recommended ([janus-idp#1705](janus-idp#1705)) ([7e24e86](janus-idp@7e24e86))
* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))
* **rbac:** implement a file watcher for csv reloads ([janus-idp#1587](janus-idp#1587)) ([62fcafc](janus-idp@62fcafc))
* **rbac:** improve conditional policy validation ([janus-idp#1673](janus-idp#1673)) ([15dac91](janus-idp@15dac91))
* **rbac:** improve validation from source ([janus-idp#1643](janus-idp#1643)) ([5f983cb](janus-idp@5f983cb))
* **rbac:** support for updating/deleting conditional permissions ([janus-idp#1628](janus-idp#1628)) ([2bb8308](janus-idp@2bb8308))
* **topology:** add permissions to topology plugin ([janus-idp#1665](janus-idp#1665)) ([9d8f244](janus-idp@9d8f244))

### Bug Fixes

* **argocd:** make refreshInterval configuration as optional ([janus-idp#1647](janus-idp#1647)) ([2c24d35](janus-idp@2c24d35))
* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **cli:** fix entrypoint validation on backstage 1.24.0 and above. ([janus-idp#1741](janus-idp#1741)) ([6ed4171](janus-idp@6ed4171))
* **config:** enable guest provider by default ([janus-idp#1661](janus-idp#1661)) ([28ac848](janus-idp@28ac848))
* **deps:** update dependency monaco-editor to ^0.49.0 ([janus-idp#1690](janus-idp#1690)) ([34308a3](janus-idp@34308a3))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **deps:** upgrade devex plugins to mui v5 ([janus-idp#1696](janus-idp#1696)) ([06d9cf0](janus-idp@06d9cf0))
* **kiali:** removing unnecessary afterAll hook ([janus-idp#1642](janus-idp#1642)) ([a314607](janus-idp@a314607))
* **lint:** ignore lint rules on generated code ([janus-idp#1668](janus-idp#1668)) ([e375c2f](janus-idp@e375c2f))
* **orchestrator:** bump `rjsf` dependencies ([janus-idp#1715](janus-idp#1715)) ([ea31cdb](janus-idp@ea31cdb))
* **orchestrator:** export the `OrchestratorPlugin` accordingly ([janus-idp#1644](janus-idp#1644)) ([4a9d1f8](janus-idp@4a9d1f8))
* **orchestrator:** fix the common package reference version ([janus-idp#1704](janus-idp#1704)) ([942b2a3](janus-idp@942b2a3))
* **orchestrator:** fixed broken workflow viewer ([janus-idp#1717](janus-idp#1717)) ([19cc79b](janus-idp@19cc79b))
* **orchestrator:** fixes many security-related issues ([janus-idp#1681](janus-idp#1681)) ([3e801c8](janus-idp@3e801c8))
* **orchestrator:** remove the need of react dev dependencies ([janus-idp#1650](janus-idp#1650)) ([5e60875](janus-idp@5e60875))
* **orchestrator:** temporarily disable plugins/orchestrator-swf-editor-envelope build ([janus-idp#1722](janus-idp#1722)) ([5c40936](janus-idp@5c40936))
* **orchestrator:** typos mentioning OpenShift ([janus-idp#1639](janus-idp#1639)) ([7ff4c75](janus-idp@7ff4c75))
* **orchestrator:** upgrade to mui v5 ([janus-idp#1727](janus-idp#1727)) ([8b935dc](janus-idp@8b935dc))
* **quay:** remove unuseful link ([janus-idp#1692](janus-idp#1692)) ([ae27d91](janus-idp@ae27d91))
* **rbac:** add proper empty page for RBAC plugin ([janus-idp#1728](janus-idp#1728)) ([79e62a6](janus-idp@79e62a6))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** conditional access form validation ([janus-idp#1699](janus-idp#1699)) ([d56f4af](janus-idp@d56f4af))
* **rbac:** do not disable already selected rule for allOf/anyOf ([janus-idp#1739](janus-idp#1739)) ([dc73650](janus-idp@dc73650))
* **rbac:** enable save on remove-all button click ([janus-idp#1712](janus-idp#1712)) ([0502332](janus-idp@0502332))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix mui autocomplete related warnings ([janus-idp#1707](janus-idp#1707)) ([8e5c5ae](janus-idp@8e5c5ae))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
* **rbac:** fix sonar cloud issues for rbac-backend plugin ([janus-idp#1619](janus-idp#1619)) ([bf93354](janus-idp@bf93354))
* **rbac:** fix to enable create and edit role buttons on having correct permissions ([janus-idp#1703](janus-idp#1703)) ([19a9088](janus-idp@19a9088))
* **rbac:** improve criteria toggle button readability on dark themes ([janus-idp#1755](janus-idp#1755)) ([345230b](janus-idp@345230b))
* **rbac:** remove token manager for auth service ([janus-idp#1632](janus-idp#1632)) ([2f19655](janus-idp@2f19655))
* **rbac:** show configure-access cta for existing simple permission policies in edit form ([janus-idp#1702](janus-idp#1702)) ([16b7e00](janus-idp@16b7e00))
* **release:** change problematic plugins to private ([janus-idp#1738](janus-idp#1738)) ([69176bd](janus-idp@69176bd))
* **scaffolder:** update annotator action readme ([janus-idp#1638](janus-idp#1638)) ([8e3af1b](janus-idp@8e3af1b))

### Documentation

* **orchestrator:** removes instructions related to the editor ([janus-idp#1664](janus-idp#1664)) ([10a75b2](janus-idp@10a75b2))

### Other changes

* **orchestrator:** add  OrchestratorClient unit tests ([janus-idp#1640](janus-idp#1640)) ([2a2dc55](janus-idp@2a2dc55))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.1.2 [skip ci]
e9f3f13 
## [1.1.2](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-rbac-node@1.1.1...@janus-idp/backstage-plugin-rbac-node@1.1.2) (2024-06-04)

### ⚠ BREAKING CHANGES

* **rbac:** This will lead to more strict validation on the source of permission policies and roles based on the where the first role is defined.

Improves the validation of the different sources of permission policies and roles. Aims to make policy definition more consistent.

Now checks if a permission policy or role with new member matches the originating role's source and prevents any action if the sources do not match. Exception includes the event of adding
new permission policies to the RBAC Admin role defined by the configuration file. Sources include 'REST, 'CSV', 'Configuration', and 'legacy'.

Before updating, ensure that you have attempted to migrate all permission policies and roles to a single source. This can be done by checking source information through the REST API and
by querying the database. Make updates through one of the available avenues: REST API, CSV file, and the database.

To view the originating source for a particular role, query the role-metadata table or use the GET roles endpoint.

* feat(rbac): remove the ability to add permission policies to configuration role

* feat(rbac): remove no longer needed check for source in EnforcerDelegate

* feat(rbac): update yarn lock

* feat(rbac): address review comments
* **rbac:** remove token manager for auth service (janus-idp#1632)

### Features

* add custom processor module to add ScaffoldedFrom relation ([janus-idp#1591](janus-idp#1591)) ([0b36164](janus-idp@0b36164))
* add method for janus-cli package metadata (simpler PR) - RHIDP-1502 ([janus-idp#1753](janus-idp#1753)) ([b81a849](janus-idp@b81a849))
* **audit-log:** add common audit-log package ([janus-idp#1622](janus-idp#1622)) ([7e0a3dd](janus-idp@7e0a3dd))
* **deps:** use RHDH themes in the backstage app and dev pages ([janus-idp#1480](janus-idp#1480)) ([8263bf0](janus-idp@8263bf0))
* **feedback:** use backstage auth service in backend plugin ([janus-idp#1646](janus-idp#1646)) ([7d9ee11](janus-idp@7d9ee11)), closes [janus-idp#1626](janus-idp#1626)
* **orchestrator:** add permissions to orchestrator plugin ([janus-idp#1599](janus-idp#1599)) ([d0a4531](janus-idp@d0a4531))
* **orchestrator:** label a Workflow assessment result as recommended ([janus-idp#1705](janus-idp#1705)) ([7e24e86](janus-idp@7e24e86))
* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))
* **rbac:** implement a file watcher for csv reloads ([janus-idp#1587](janus-idp#1587)) ([62fcafc](janus-idp@62fcafc))
* **rbac:** improve conditional policy validation ([janus-idp#1673](janus-idp#1673)) ([15dac91](janus-idp@15dac91))
* **rbac:** improve validation from source ([janus-idp#1643](janus-idp#1643)) ([5f983cb](janus-idp@5f983cb))
* **rbac:** support for updating/deleting conditional permissions ([janus-idp#1628](janus-idp#1628)) ([2bb8308](janus-idp@2bb8308))
* **topology:** add permissions to topology plugin ([janus-idp#1665](janus-idp#1665)) ([9d8f244](janus-idp@9d8f244))

### Bug Fixes

* **argocd:** make refreshInterval configuration as optional ([janus-idp#1647](janus-idp#1647)) ([2c24d35](janus-idp@2c24d35))
* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **cli:** fix entrypoint validation on backstage 1.24.0 and above. ([janus-idp#1741](janus-idp#1741)) ([6ed4171](janus-idp@6ed4171))
* **config:** enable guest provider by default ([janus-idp#1661](janus-idp#1661)) ([28ac848](janus-idp@28ac848))
* **deps:** update dependency monaco-editor to ^0.49.0 ([janus-idp#1690](janus-idp#1690)) ([34308a3](janus-idp@34308a3))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **deps:** upgrade devex plugins to mui v5 ([janus-idp#1696](janus-idp#1696)) ([06d9cf0](janus-idp@06d9cf0))
* **kiali:** removing unnecessary afterAll hook ([janus-idp#1642](janus-idp#1642)) ([a314607](janus-idp@a314607))
* **lint:** ignore lint rules on generated code ([janus-idp#1668](janus-idp#1668)) ([e375c2f](janus-idp@e375c2f))
* **orchestrator:** bump `rjsf` dependencies ([janus-idp#1715](janus-idp#1715)) ([ea31cdb](janus-idp@ea31cdb))
* **orchestrator:** export the `OrchestratorPlugin` accordingly ([janus-idp#1644](janus-idp#1644)) ([4a9d1f8](janus-idp@4a9d1f8))
* **orchestrator:** fix the common package reference version ([janus-idp#1704](janus-idp#1704)) ([942b2a3](janus-idp@942b2a3))
* **orchestrator:** fixed broken workflow viewer ([janus-idp#1717](janus-idp#1717)) ([19cc79b](janus-idp@19cc79b))
* **orchestrator:** fixes many security-related issues ([janus-idp#1681](janus-idp#1681)) ([3e801c8](janus-idp@3e801c8))
* **orchestrator:** remove the need of react dev dependencies ([janus-idp#1650](janus-idp#1650)) ([5e60875](janus-idp@5e60875))
* **orchestrator:** temporarily disable plugins/orchestrator-swf-editor-envelope build ([janus-idp#1722](janus-idp#1722)) ([5c40936](janus-idp@5c40936))
* **orchestrator:** typos mentioning OpenShift ([janus-idp#1639](janus-idp#1639)) ([7ff4c75](janus-idp@7ff4c75))
* **orchestrator:** upgrade to mui v5 ([janus-idp#1727](janus-idp#1727)) ([8b935dc](janus-idp@8b935dc))
* **quay:** remove unuseful link ([janus-idp#1692](janus-idp#1692)) ([ae27d91](janus-idp@ae27d91))
* **rbac:** add proper empty page for RBAC plugin ([janus-idp#1728](janus-idp#1728)) ([79e62a6](janus-idp@79e62a6))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** conditional access form validation ([janus-idp#1699](janus-idp#1699)) ([d56f4af](janus-idp@d56f4af))
* **rbac:** do not disable already selected rule for allOf/anyOf ([janus-idp#1739](janus-idp#1739)) ([dc73650](janus-idp@dc73650))
* **rbac:** enable save on remove-all button click ([janus-idp#1712](janus-idp#1712)) ([0502332](janus-idp@0502332))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix mui autocomplete related warnings ([janus-idp#1707](janus-idp#1707)) ([8e5c5ae](janus-idp@8e5c5ae))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
* **rbac:** fix sonar cloud issues for rbac-backend plugin ([janus-idp#1619](janus-idp#1619)) ([bf93354](janus-idp@bf93354))
* **rbac:** fix to enable create and edit role buttons on having correct permissions ([janus-idp#1703](janus-idp#1703)) ([19a9088](janus-idp@19a9088))
* **rbac:** improve criteria toggle button readability on dark themes ([janus-idp#1755](janus-idp#1755)) ([345230b](janus-idp@345230b))
* **rbac:** remove token manager for auth service ([janus-idp#1632](janus-idp#1632)) ([2f19655](janus-idp@2f19655))
* **rbac:** show configure-access cta for existing simple permission policies in edit form ([janus-idp#1702](janus-idp#1702)) ([16b7e00](janus-idp@16b7e00))
* **release:** change problematic plugins to private ([janus-idp#1738](janus-idp#1738)) ([69176bd](janus-idp@69176bd))
* **scaffolder:** update annotator action readme ([janus-idp#1638](janus-idp#1638)) ([8e3af1b](janus-idp@8e3af1b))

### Documentation

* **orchestrator:** removes instructions related to the editor ([janus-idp#1664](janus-idp#1664)) ([10a75b2](janus-idp@10a75b2))

### Other changes

* **orchestrator:** add  OrchestratorClient unit tests ([janus-idp#1640](janus-idp#1640)) ([2a2dc55](janus-idp@2a2dc55))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.4.11 [skip ci]
b418132 
## [1.4.11](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-scaffolder-backend-module-regex@1.4.10...@janus-idp/backstage-scaffolder-backend-module-regex@1.4.11) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.4.13 [skip ci]
56c4d01 
## [1.4.13](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-scaffolder-backend-module-servicenow@1.4.12...@janus-idp/backstage-scaffolder-backend-module-servicenow@1.4.13) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 2.6.4 [skip ci]
1ac686e 
## [2.6.4](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/shared-react@2.6.3...@janus-idp/shared-react@2.6.4) (2024-06-04)

### ⚠ BREAKING CHANGES

* **rbac:** This will lead to more strict validation on the source of permission policies and roles based on the where the first role is defined.

Improves the validation of the different sources of permission policies and roles. Aims to make policy definition more consistent.

Now checks if a permission policy or role with new member matches the originating role's source and prevents any action if the sources do not match. Exception includes the event of adding
new permission policies to the RBAC Admin role defined by the configuration file. Sources include 'REST, 'CSV', 'Configuration', and 'legacy'.

Before updating, ensure that you have attempted to migrate all permission policies and roles to a single source. This can be done by checking source information through the REST API and
by querying the database. Make updates through one of the available avenues: REST API, CSV file, and the database.

To view the originating source for a particular role, query the role-metadata table or use the GET roles endpoint.

* feat(rbac): remove the ability to add permission policies to configuration role

* feat(rbac): remove no longer needed check for source in EnforcerDelegate

* feat(rbac): update yarn lock

* feat(rbac): address review comments

### Features

* add method for janus-cli package metadata (simpler PR) - RHIDP-1502 ([janus-idp#1753](janus-idp#1753)) ([b81a849](janus-idp@b81a849))
* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))
* **rbac:** improve validation from source ([janus-idp#1643](janus-idp#1643)) ([5f983cb](janus-idp@5f983cb))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **cli:** fix entrypoint validation on backstage 1.24.0 and above. ([janus-idp#1741](janus-idp#1741)) ([6ed4171](janus-idp@6ed4171))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add proper empty page for RBAC plugin ([janus-idp#1728](janus-idp#1728)) ([79e62a6](janus-idp@79e62a6))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** do not disable already selected rule for allOf/anyOf ([janus-idp#1739](janus-idp#1739)) ([dc73650](janus-idp@dc73650))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
* **rbac:** fix to enable create and edit role buttons on having correct permissions ([janus-idp#1703](janus-idp#1703)) ([19a9088](janus-idp@19a9088))
* **rbac:** improve criteria toggle button readability on dark themes ([janus-idp#1755](janus-idp#1755)) ([345230b](janus-idp@345230b))
* **rbac:** show configure-access cta for existing simple permission policies in edit form ([janus-idp#1702](janus-idp#1702)) ([16b7e00](janus-idp@16b7e00))
* **scaffolder:** update annotator action readme ([janus-idp#1638](janus-idp#1638)) ([8e3af1b](janus-idp@8e3af1b))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.4.11 [skip ci]
b24b9c2 
## [1.4.11](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-scaffolder-backend-module-sonarqube@1.4.10...@janus-idp/backstage-scaffolder-backend-module-sonarqube@1.4.11) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 3.7.6 [skip ci]
000daaf 
## [3.7.6](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-tekton@3.7.5...@janus-idp/backstage-plugin-tekton@3.7.6) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([janus-idp#1730](janus-idp#1730)) ([379c241](janus-idp@379c241))
* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.21.8 [skip ci]
15f9c35 
## [1.21.8](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-topology@1.21.7...@janus-idp/backstage-plugin-topology@1.21.8) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Jun 5, 2024
@semantic-release-bot @04kash
chore(release): 1.5.7 [skip ci]
b777625 
## [1.5.7](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/backstage-plugin-web-terminal@1.5.6...@janus-idp/backstage-plugin-web-terminal@1.5.7) (2024-06-04)

### Features

* **rbac:** add audit log for RBAC backend ([janus-idp#1726](janus-idp#1726)) ([e50464b](janus-idp@e50464b))

### Bug Fixes

* **deps:** update kiali dependencies (minor) ([janus-idp#1779](janus-idp#1779)) ([ff2b421](janus-idp@ff2b421))
* **rbac:** add support for scaling ([janus-idp#1757](janus-idp#1757)) ([caddc83](janus-idp@caddc83))
* **rbac:** fix handling condition action conflicts ([janus-idp#1781](janus-idp#1781)) ([966b2b2](janus-idp@966b2b2))
* **rbac:** fix role list view permission policies column value ([janus-idp#1714](janus-idp#1714)) ([07200e4](janus-idp@07200e4))
janus-idp bot pushed a commit that referenced this pull request Jun 5, 2024
@semantic-release-bot
chore(release): 1.10.0 [skip ci]
d9c4a5a 
## [1.10.0](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/cli@1.9.0...@janus-idp/cli@1.10.0) (2024-06-05)

### Features

* **rbac:** add audit log for RBAC backend ([#1726](#1726)) ([e50464b](e50464b))
* switch defaults of the `--embed-as-dependencies` and `in-place` options. ([#1787](#1787)) ([049e675](049e675))

### Bug Fixes

* **audit-log:** deep copy objects passed into audit logger so redactor will not modify objects and remove `auditErrorLog` function ([#1730](#1730)) ([379c241](379c241))
* **deps:** update kiali dependencies (minor) ([#1779](#1779)) ([ff2b421](ff2b421))
* **rbac:** add support for scaling ([#1757](#1757)) ([caddc83](caddc83))
* **rbac:** fix handling condition action conflicts ([#1781](#1781)) ([966b2b2](966b2b2))
* **rbac:** fix role list view permission policies column value ([#1714](#1714)) ([07200e4](07200e4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-tsao kim-tsao Awaiting requested review from kim-tsao

@schultzp2020 schultzp2020 Awaiting requested review from schultzp2020

@debsmita1 debsmita1 Awaiting requested review from debsmita1

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

Assignees

@divyanshiGupta divyanshiGupta

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ciiay @ShiranHi @divyanshiGupta