Skip to content

Commit

Permalink
Fix typo in the dynamic-plugins docs' package.json configurations (#702)
Browse files Browse the repository at this point in the history
* Fix typo in dynamic-plugins.md package.json configurations

* Update the `export-dynamic` script to use janus-cli

* Update janus-cli version and fix quotations

* chore: address review comments

Co-authored-by: David Festal <dfestal@redhat.com>

---------

Co-authored-by: David Festal <dfestal@redhat.com>
Co-authored-by: Tomas Kral <tkral@redhat.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
  • Loading branch information
4 people committed Nov 3, 2023
1 parent 957efc8 commit 58ed7c0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions showcase-docs/dynamic-plugins.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,18 +45,18 @@ These recommended changes to the `package.json` are summarized below:
...
"scripts": {
...
"export-dynamic": "backstage-cli package export-dynamic-plugin"
"export-dynamic": "janus-cli package export-dynamic-plugin"
...
},
...
"dependencies": {
...
"@backstage/backend-plugin-manager": "npm:janus-idp/backend-plugin-manager@0.0.5-janus.0",
"@backstage/backend-plugin-manager": "npm:@janus-idp/backend-plugin-manager@v1.19.6",
...
}
...
"devDependencies": {
"@janus-idp/cli": "1.1.0
"@janus-idp/cli": "1.3.1"
},
...
"files": [
Expand Down

0 comments on commit 58ed7c0

Please sign in to comment.