Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the dynamic-plugins docs' package.json configurations #702

Merged
merged 11 commits into from
Nov 3, 2023

Conversation

Zaperex
Copy link
Member

@Zaperex Zaperex commented Nov 1, 2023

Description

Fix typo in dynamic-plugins docs' package.json configurations
The current "recommended" package.json configuration will cause the yarn install and yarn add to fail due to npm:janus-idp/backend-plugin-manager@0.0.5-janus.0 not being a valid package.

There is also a bug in the recommended export-dynamic script, which uses backstage-cli (the package export-dynamic-plugins command does not exist in upstream cli) instead of janus-cli.

Which issue(s) does this PR fix

N/A

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@Zaperex Zaperex requested a review from a team as a code owner November 1, 2023 20:06
Copy link

changeset-bot bot commented Nov 1, 2023

⚠️ No Changeset found

Latest commit: f5e015a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Zaperex Zaperex requested review from davidfestal and schultzp2020 and removed request for a team November 1, 2023 20:06
showcase-docs/dynamic-plugins.md Outdated Show resolved Hide resolved
Zaperex and others added 2 commits November 2, 2023 09:04
Co-authored-by: David Festal <dfestal@redhat.com>
Copy link

sonarcloud bot commented Nov 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
17.7% 17.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@kadel kadel merged commit 58ed7c0 into janus-idp:main Nov 3, 2023
1 of 2 checks passed
@Zaperex Zaperex deleted the patch-1 branch November 3, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants