-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in the dynamic-plugins docs' package.json configurations #702
Conversation
|
Co-authored-by: David Festal <dfestal@redhat.com>
SonarCloud Quality Gate failed.
|
Description
Fix typo in dynamic-plugins docs'
package.json
configurationsThe current "recommended"
package.json
configuration will cause theyarn install
andyarn add
to fail due tonpm:janus-idp/backend-plugin-manager@0.0.5-janus.0
not being a valid package.There is also a bug in the recommended
export-dynamic
script, which usesbackstage-cli
(thepackage export-dynamic-plugins
command does not exist in upstream cli) instead ofjanus-cli
.Which issue(s) does this PR fix
N/A
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer