Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHIDP-2067 [QE] Automate Scenario - Support external postgres databases #1292

Merged
merged 1 commit into from
May 31, 2024

Conversation

gustavolira
Copy link
Contributor

Description

Manual test to verify external PostgreSQL installation.
https://issues.redhat.com/browse/RHIDP-2067

Created a manual-tests folder which will contain all new manual tests from now on. This will help identify which manual tests need to be run.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@gustavolira gustavolira requested a review from a team as a code owner May 31, 2024 14:49
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1292!


HELM_IMAGE_NAME=backstage
HELM_REPO_NAME=rhdh-chart
HELM_REPO_URL="https://redhat-developer.github.io/rhdh-chart"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this use the production helm chart?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rnapoles-rh we can change the helm chart for whatever we want change only changing the variables HELM_REPO_URL, HELM_REPO_NAME, HELM_IMAGE_NAME

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thx

@josephca josephca dismissed their stale review May 31, 2024 17:27

The credential is a place holder. Dropping this request

Signed-off-by: Gustavo Lira <guga.java@gmail.com>
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.2% Duplication on New Code

See analysis details on SonarCloud

@josephca
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label May 31, 2024
Copy link

openshift-ci bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1292!

@openshift-merge-bot openshift-merge-bot bot merged commit 0fbc913 into janus-idp:main May 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants