Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update to mkdocs-techdocs-core==1.4.0 and plantuml-markdown>=3.9.7 (if possible) as cachito is failing to resolve plantuml-markdown-3.9.7.tar.gz for some reason #1407

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

nickboldt
Copy link
Member

@nickboldt nickboldt commented Jul 17, 2024

What does this PR do?

chore(deps): update to mkdocs-techdocs-core==1.4.0 and plantuml-markdown>=3.9.7 (if possible) as cachito is failing to resolve plantuml-markdown-3.9.7.tar.gz for some reason

Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/RHIDP-1551

How to test this PR?

see https://gitlab.cee.redhat.com/rhidp/rhdh/-/jobs/24110413

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@nickboldt nickboldt requested a review from a team as a code owner July 17, 2024 12:21
Copy link

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nickboldt. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt nickboldt changed the title chore(deps): update to... chore(deps): update to mkdocs-techdocs-core==1.4.0 and plantuml-markdown>=3.9.7 (if possible) as cachito is failing to resolve plantuml-markdown-3.9.7.tar.gz for some reason Jul 17, 2024
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1407!

Copy link

openshift-ci bot commented Jul 17, 2024

@nickboldt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests a7d82c2 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nickboldt nickboldt force-pushed the downstream-cachito-fails-plantuml-markdown-3.9.27 branch from a7d82c2 to 2818881 Compare July 18, 2024 00:37
Copy link

sonarcloud bot commented Jul 18, 2024

@nickboldt nickboldt merged commit 3d9677a into main Jul 18, 2024
4 of 6 checks passed
@nickboldt nickboldt deleted the downstream-cachito-fails-plantuml-markdown-3.9.27 branch July 18, 2024 00:37
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1407!

kadel pushed a commit to kadel/backstage-showcase that referenced this pull request Aug 7, 2024
…own>=3.9.7 (if possible) as cachito is failing to resolve plantuml-markdown-3.9.7.tar.gz for some reason (janus-idp#1407)

* chore(deps): update to mkdocs-techdocs-core==1.4.0 and plantuml-markdown>=3.9.7 (if possible) as cachito is failing to resolve plantuml-markdown-3.9.7.tar.gz for some reason

Signed-off-by: Nick Boldt <nboldt@redhat.com>

* switch to plantuml-markdown-3.9.7 from from sources plantuml-markdown @ https://github.com/mikitex70/plantuml-markdown/archive/fcf62aa930708368ec1daaad8b5b5dbe1d1b2014.zip#cachito_hash=sha256:a487c2312a53fe47a0947e8624290b2c8ea51e373140d02950531966b1db5caa

Signed-off-by: Nick Boldt <nboldt@redhat.com>

---------

Signed-off-by: Nick Boldt <nboldt@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant