RHIDP-2128 [Test automation] Establish AKS nightly tests #1472
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test all |
|
The image is available at: |
|
/test all |
|
The image is available at: |
|
/test all |
|
The image is available at: |
|
/test all |
zdrapela
changed the title
|
The image is available at: |
1 similar comment
|
The image is available at: |
|
/test all |
|
The image is available at: |
|
/test all |
| @@ -14,6 +14,7 @@ | |||
| "showcase-rbac-1-2-x": "playwright test --project=showcase-rbac", | |||
| "showcase-ci-nightly": "playwright test --project=showcase", | |||
| "showcase-rbac-nightly": "playwright test --project=showcase-rbac", | |||
| "showcase-aks-ci-nightly": "playwright test --project=showcase-aks", | |||
There was a problem hiding this comment.
We can use existing showcase-ci-nightly and showcase-rbac-nightly
| @@ -62,6 +62,25 @@ export default defineConfig({ | |||
| '**/playwright/e2e/verify-tls-config-with-external-postgres-db.spec.ts', | |||
| ], | |||
| }, | |||
| { | |||
| name: 'showcase-aks', | |||
There was a problem hiding this comment.
any specific idea to have new project? I guess we want to run all tests on AKS.
There was a problem hiding this comment.
I've got a two reasons for that:
- we can start running tests on AKS before we do the manual setup that is needed for running all the tests (RHIDP-2128 demands installation and Azure integration tests only)
- I believe that some tests might break only on AKS and it is good to have an option to disable them only for AKS
There was a problem hiding this comment.
Agree, lets keep this way then.
There was a problem hiding this comment.
I guess we are good with using existing value files for rbac and non-rbac. creating new value files will make things complex in future.
There was a problem hiding this comment.
The config for AKS is slightly different. We might use the same file, but we will have to change it through the Helm install. I agree that maintaining two value files is worse than one. It is not that much values so it can be possible to change the values through the Helm install for AKS and use just one values file (well, one for non-RBAC, one for RBAC).
There was a problem hiding this comment.
I added diff-values_showcase_AKS.yaml file instead and use the values_showcase.yaml as a base. Both of the files are applied by helm upgrade -i https://github.com/janus-idp/backstage-showcase/pull/1472/files#diff-4d6549ba4c59a94aab379c14838198870ef2e610c26348b6c58c6fbffedc479bR372
| echo "OCP version: $(oc version)" | ||
|
|
||
| API_SERVER_URL=$(oc whoami --show-server) | ||
| K8S_CLUSTER_ROUTER_BASE=$(oc get route console -n openshift-console -o=jsonpath='{.spec.host}' | sed 's/^[^.]*\.//') | ||
| if [[ "$JOB_NAME" == *aks* ]]; then | ||
| K8S_CLUSTER_ROUTER_BASE=$(kubectl get svc nginx --namespace app-routing-system -o jsonpath='{.status.loadBalancer.ingress[0].ip}') |
There was a problem hiding this comment.
what if there is no nginx running, It will fail here.
There was a problem hiding this comment.
I agree that it would be better to make sure it runs and enable it if it's not. As it is now, enabling it would be a manual step for setting up the cluster before using it for running tests.
There was a problem hiding this comment.
I added this to make sure it is enabled: https://github.com/janus-idp/backstage-showcase/pull/1472/files#diff-4d6549ba4c59a94aab379c14838198870ef2e610c26348b6c58c6fbffedc479bR392
| @@ -360,23 +398,32 @@ main() { | |||
| NAME_SPACE="showcase-ci-nightly" | |||
| NAME_SPACE_RBAC="showcase-rbac-nightly" | |||
| NAME_SPACE_POSTGRES_DB="postgress-external-db-nightly" | |||
| NAME_SPACE_AKS="showcase-aks-ci-nightly" | |||
There was a problem hiding this comment.
new namespace is not needed, I guess idea is to deploy existing namespace showcase-ci-nightly and showcase-rbac-nightly on AKS cluster.
There was a problem hiding this comment.
Right now, project that yarn runs the playwright tests for depends on the namespace name. So if we want different project for AKS, we need a different namespace, or change the script to use different value for that
backstage-showcase/e2e-tests/package.json
Line 17 in 5b48b6f
|
/test all |
|
The image is available at: |
1 similar comment
|
The image is available at: |
|
/test all |
|
The image is available at: |
|
|
@zdrapela: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The image is available at: |
Description
This PR is making it possible to test RHDH installation on AKS. E2E tests are limited to those that run immediately without further configuration of the cluster (skipped tests defined in:
e2e-tests/playwright.config.ts). GitHub would be working, but we reached the maximum number of callback URLs.To distinguish which configuration should be applied, the
if [[ "$JOB_NAME" == *aks* ]]condition is used in.ibm/pipelines/openshift-ci-tests.sh.It uses different value file for AKS instance:
.ibm/pipelines/value_files/values_showcase_AKS.yamlThis PR adds the Azure CLI to the Dockerfile. The AKS test uses it to start the cluster and then to stop it after the test finishes. The account for Azure CLI was established using https://github.com/adrianriobo/mapt/blob/fix-272/hacks/azure/azure_setup.sh
I'm switching the
analyticsplugin test so:Testing, that it is disabled, is more important and this switch makes it possible to run this test on AKS straight away.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer