-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dynamic-plugins-info
backend plugin
#638
Conversation
🦋 Changeset detectedLatest commit: fae9646 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The image is available at: |
The image is available at: |
@Zaperex Do you think something can be done to reduce the code duplication raised by SonarCloud ? |
Hmm it's flagging the mock data and mock result which are very similar. I guess I can try to get sonarcloud to ignore those files? |
The image is available at: |
The image is available at: |
@Zaperex can you please rebase resolve conflicts so we can merge it? |
Currently having issues creating a merge commit due to Abridged Error Logs> yarn lint-staged
yarn run v1.22.19
$ lint-staged
✔ Preparing lint-staged...
⚠ Running tasks for staged files...
❯ package.json — 167 files
❯ * — 167 files
✖ turbo run prettier:fix -- [KILLED]
❯ *.{jsx,ts,tsx,mjs,cjs} — 56 files
✖ turbo run lint --concurrency=1 -- --fix [KILLED]
❯ !(.eslintrc).js — 1 file
✖ turbo run lint --concurrency=1 -- --fix [FAILED]
↓ Skipped because of errors from tasks.
✔ Reverting to original state because of errors...
✔ Cleaning up temporary files...
✖ turbo run lint --concurrency=1 -- --fix:
roadiehq-backstage-plugin-argo-cd-backend:lint: ERROR: command finished with error: command (/home/frkong/coding/janus-idp/backstage-showcase/dynamic-plugins/wrappers/roadiehq-backstage-plugin-argo-cd-backend-dynamic) yarn run lint --fix /home/frkong/coding/janus-idp/backstage-showcase/e2e-test/cypress/plugins/index.js exited (1)
roadiehq-backstage-plugin-argo-cd-backend#lint: command (/home/frkong/coding/janus-idp/backstage-showcase/dynamic-plugins/wrappers/roadiehq-backstage-plugin-argo-cd-backend-dynamic) yarn run lint --fix /home/frkong/coding/janus-idp/backstage-showcase/e2e-test/cypress/plugins/index.js exited (1)
ERROR run failed: command exited (1)
• Packages in scope: @internal/plugin-dynamic-plugins-info-backend, @internal/plugin-scalprum-backend, app, backend, backstage-plugin-azure-devops-backend, backstage-plugin-catalog-backend-module-github, backstage-plugin-catalog-backend-module-github-org, backstage-plugin-catalog-backend-module-gitlab, backstage-plugin-jenkins-backend, backstage-plugin-kubernetes-backend, backstage-plugin-scaffolder-backend-module-gitlab, backstage-plugin-sonarqube-backend, backstage-plugin-techdocs-backend, dynamic-plugins-imports, dynamic-plugins-utils, immobiliarelabs-backstage-plugin-gitlab-backend, janus-idp-backstage-plugin-aap-backend, janus-idp-backstage-plugin-keycloak-backend, janus-idp-backstage-plugin-ocm-backend, roadiehq-backstage-plugin-argo-cd-backend, roadiehq-scaffolder-backend-argocd, roadiehq-scaffolder-backend-module-utils
• Running lint in 22 packages
• Remote caching disabled
roadiehq-backstage-plugin-argo-cd-backend:lint: cache miss, executing dfb189c16ec31382
$ backstage-cli package lint --fix /home/frkong/coding/janus-idp/backstage-showcase/e2e-test/cypress/plugins/index.js
roadiehq-backstage-plugin-argo-cd-backend:lint:
roadiehq-backstage-plugin-argo-cd-backend:lint:
roadiehq-backstage-plugin-argo-cd-backend:lint: ✘ http://eslint.org/docs/rules/
roadiehq-backstage-plugin-argo-cd-backend:lint:
roadiehq-backstage-plugin-argo-cd-backend:lint: Parsing error: Cannot read file '/home/frkong/coding/janus-idp/backstage-showcase/dynamic-plugins/wrappers/roadiehq-backstage-plugin-argo-cd-backend-dynamic/tsconfig.json'
roadiehq-backstage-plugin-argo-cd-backend:lint:
roadiehq-backstage-plugin-argo-cd-backend:lint:
roadiehq-backstage-plugin-argo-cd-backend:lint: e2e-test/cypress/plugins/index.js:0:0
roadiehq-backstage-plugin-argo-cd-backend:lint:
roadiehq-backstage-plugin-argo-cd-backend:lint: ✘ 1 problem (1 error, 0 warnings)
roadiehq-backstage-plugin-argo-cd-backend:lint:
roadiehq-backstage-plugin-argo-cd-backend:lint:
roadiehq-backstage-plugin-argo-cd-backend:lint: Errors:
roadiehq-backstage-plugin-argo-cd-backend:lint: 1 http://eslint.org/docs/rules/null
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. I will resolve the conflicts in the github web UI for now. |
b57cfe2
to
a37c375
Compare
For the sonarcloud code analysis, should I just remove the test data? |
The image is available at: |
The image is available at: |
The image is available at: |
Co-authored-by: Tomas Kral <tomas.kral@gmail.com>
a22d638
to
149b385
Compare
…into list-dynamic-plugins
SonarCloud Quality Gate failed.
|
sorry, I already deleted the original comment when I noticed that one has |
The image is available at: |
Description
Adds the
dynamic-plugins-info
backend plugin that provides the currently installed dynamic plugins in the backstage instance.Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
Please let me know if there's a better name for this plugin, the
dynamic-plugins-info
is just a placeholder name for now.