Re-initialize project with operator-sdk and go.kubebuilder.io/v3 plugin #22
Conversation
jianrongzhang89
force-pushed
the
project-init
branch
from
2e6b812
to
da96383
Compare
jianrongzhang89
changed the title
| @@ -1,20 +1,18 @@ | |||
| # Adds namespace to all resources. | |||
| namespace: backstage-system | |||
| namespace: operator-system | |||
There was a problem hiding this comment.
Can this be prefixed with backstage- as before? I noticed that the operator was installed into an operator-system namespace and the Deployment was named operator-controller-manager, which IMO might be confusing to people installing the operator.
|
|
||
| # Value of this field is prepended to the | ||
| # names of all resources, e.g. a deployment named | ||
| # "wordpress" becomes "alices-wordpress". | ||
| # Note that it should also match with the prefix (text before '-') of the namespace | ||
| # field above. | ||
| namePrefix: backstage- | ||
| namePrefix: operator- |
There was a problem hiding this comment.
Same point as the previous comment.
| @@ -1,71 +1,80 @@ | |||
| module backstage.io/backstage-deploy-operator | |||
| module backstage.io/backstage-operator | |||
There was a problem hiding this comment.
I'm also wondering if the module name should not be changed to github.com/janus-idp/operator..
There was a problem hiding this comment.
Added a few more comments. But I guess all those comments can be resolved with the right operator-sdk init flags. I was able to get the intended result with the command below. WDYT?
$ operator-sdk init \
--plugins go/v3 \
--project-version 3 \
--domain janus-idp.io \
--repo github.com/janus-idp/operator \
--project-name backstage-operator \
--owner "Red Hat"
There was a problem hiding this comment.
nit:
The Copyright notice currently shows: "Copyright 2023". I noticed operator-sdk init had a --owner flag to update that. So maybe we could use it: operator-sdk init [...] --owner "Red Hat"..
There was a problem hiding this comment.
Looking at the old backstage operator (https://github.com/janus-idp/backstage-operator/blob/main/PROJECT), I think we could use the following values:
domaincould be:janus-idp.ioprojectNamecould be:backstage-operatorrepocould be:github.com/janus-idp/operator
There was a problem hiding this comment.
As Armal mentioned, there are several things in PROJECT (I do not think very important) and some in generated kustomize (more interesting but can be fixed later)
It works and I'd prefer to merge it sooner than later to not blocking everything else, so basically LGTM.
👍🏿 Let's do that in subsequent issues/PRs later. /lgtm |
To not forget about it: #23 |
No description provided.