This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layered operator #272
Layered operator #272
Changes from all commits
cfb83b2
c952470
9563358
46f0e7f
99b4e54
cffa417
2bf0716
47ba2f9
5882f62
4863874
4bdb1a0
971a50c
93d3de7
6da447e
8d8b84c
f6a37c0
ac60557
eb5f305
19d923d
267a166
20fbc03
089f56c
a1a671a
a138de1
48a88ab
8436faa
18119c6
7f937ba
bb311a7
63254a0
3ddc1a6
a8546da
e01826c
f413fc4
6df33bd
14dfdc6
9517959
e24518d
90acacd
e9e115e
2bd9697
aca67ba
fd2e042
3a58242
6c5cb9d
2c44c4e
245c6c1
3877ae9
2dceb0d
da7d4cd
ee7654e
dcd9d92
98255bb
6debb33
0d4552d
b087290
52c9b87
abfd664
a6d4d79
169732b
e40d734
69cbc81
896c21a
157f98c
017ccf7
29b713c
50d9c2d
da0509a
d8d68fa
a9ecc07
a8dca90
0ec603d
0e3135b
cf13c40
428859f
4e189d5
6e112c5
2097441
71c5fe9
246064c
9a7d5aa
d2d5f96
2f4c3e9
31e29a3
2218fa3
9817300
49616e5
6d4dbfe
30dd487
7b9c6a1
15daa4e
7d96f67
ddf9b7f
167874a
c3d2834
68b2cc1
e9cfde0
903b8c1
0bb142b
b6f0110
c683ecb
61e8283
84d7218
da211c0
9b5bdd8
caadc50
228172a
14668bf
e6dab7e
680d818
d9b076f
d6686ff
00f56bf
c02120a
50d3c41
333b9f0
c7ba44c
29f7904
ab42ffe
71460b2
3ab0b87
ca782d6
4744fa3
72d133c
99c7dea
38b1ff6
dda51d9
f1bbe11
39cab1d
1bfb4ce
5e87394
265b62f
5fab29b
6714198
0ea1ad9
98165f5
48f030c
4684eda
2a5b99a
f675802
a786b66
2cda2c1
53e7603
7b01131
4cdc82d
3df1099
4b06b33
791c842
3782e36
6702639
9258f9f
d9ecb8e
4a95038
a58257d
f6de7ae
3bdb65c
a39b42f
63b4944
0f339b9
0d4ea58
eab0ffe
0f15e00
d2dd31e
56e8f77
a6506ae
e84d054
ee299e8
fd77255
da2b990
e6c56ce
ab6b1bd
9f9829d
73f77d0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be a potential breaking change. How would we distinguish between "this field is set to an empty list in the CR" vs "this field is not set in the CR"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If ImagePullSecrets []string is not defined it contains nil pointer
If ImagePullSecrets []string is initialized with empty array it contains pointer to empty slice with len:0 and cap:0
So, yes we can distinguish just checking ImagePullSecrets == nil
Is it what you're asking about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is just that, as it is, the way it is iterated upon in this PR (https://github.com/gazarenkov/janus-idp-operator/blob/e6c56cecebf4f76748e8c80903059593e7fd78a8/pkg/model/deployment.go#L188-L191) will never allow CR users to explicitly set this list to an empty list.
This used to work previously (see
operator/controllers/backstage_deployment.go
Lines 219 to 224 in 496da58
imagePullSecrets: []
in my CR, the resulting Deployment won't have any pull secrets defined, and if I don't setimagePullSecrets
in the CR, it will inherit those coming from the operator/raw config.But this can be tackled in a separate issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, got it, indeed, if imagePullSecrets: [] it is logically to clean defaults, should not be difficult will make an issue for it.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.