Enable Operator for restricted network environments #86
Conversation
| @@ -198,6 +201,11 @@ spec: | |||
| - --leader-elect | |||
| command: | |||
| - /manager | |||
| env: | |||
| - name: POSTGRESQL_IMAGE | |||
There was a problem hiding this comment.
we might need to prefix these variables with RELATED_IMAGE_ so that the downstream build can automatically collect them into spec.relatedImages.
There was a problem hiding this comment.
Sounds good. Updated the PR.
| Scheme: k8sClient.Scheme(), | ||
| Namespace: ns, | ||
| OwnsRuntime: true, | ||
| PsqlImage: "quay.io/fedora/postgresql-15:latest", |
There was a problem hiding this comment.
Could you please specify how it was tested with restricted network environment?
As I understand (according to previous discussion) we specifically interested in testing SCV based installation.
Can you provide this information please.
There was a problem hiding this comment.
The automated test cases do not actually pull images from external resources. Changed to use dummy values.
@nickboldt Could you let us know how the test can be done on the restricted network environment?
Description
Use environment variables POSTGRESQL_IMAGE and BACKSTAGE_IMAGE to the operator container to indicate the default images used by the operator to deploy psql db and backstage application, respectively.
Note that:
a) If the psql db statefulset has image unset, or set to the special string {POSTGRESQL_IMAGE}, the operator will replace it with the value of the environment variable POSTGRESQL_IMAGE. Similarly BACKSTAGE_IMAGE is introdiced for the backstage deployment object.
b) The user can still override the backstage image using the Backstage CR spec.application.image field.
Which issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer
Deploy the operator and the examples CRs. Check that the backstage app and psql db pods are running successfully.