Skip to content

Commit

Permalink
[Release/5.0] - Fix versions for Libs native artifacts
Browse files Browse the repository at this point in the history
Port of dotnet#52799 and dotnet#52917

During the repo consolidation, we missed passing OfficialBuildId
argument to common script from all subsets, which resulted in default
version emitted in the binaries produced by Libs subset in the official
builds.
  • Loading branch information
janvorli committed May 19, 2021
1 parent fb2db27 commit d9951ed
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/libraries/Native/build-native.proj
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<NativeVersionFile Condition="'$(TargetOS)' != 'Windows_NT'">$(ArtifactsObjDir)_version.c</NativeVersionFile>
<TargetFramework>$(BuildTargetFramework)</TargetFramework>
<TargetFramework Condition="'$(TargetFramework)' == ''">$(NetCoreAppCurrent)</TargetFramework>
<_BuildNativeArgs>$(TargetArchitecture) $(Configuration) outconfig $(TargetFramework)-$(TargetOS)-$(Configuration)-$(TargetArchitecture) -os $(TargetOS)</_BuildNativeArgs>
<_BuildNativeArgs>$(TargetArchitecture) $(Configuration) outconfig $(TargetFramework)-$(TargetOS)-$(Configuration)-$(TargetArchitecture) -os $(TargetOS) /p:OfficialBuildId="$(OfficialBuildId)"</_BuildNativeArgs>
</PropertyGroup>

<ItemGroup>
Expand Down

0 comments on commit d9951ed

Please sign in to comment.