Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ld: discard the .note.gnu.build-id section #68

Merged
merged 2 commits into from
Nov 18, 2016
Merged

ld: discard the .note.gnu.build-id section #68

merged 2 commits into from
Nov 18, 2016

Conversation

japaric
Copy link
Owner

@japaric japaric commented Nov 17, 2016

old versions of gcc insert this into the executable but this causes
problem because this section places itself at the beginning of the .text
section thus filling the vector table with wrong values.

@japaric
Copy link
Owner Author

japaric commented Nov 17, 2016

@homunkulus r+

@homunkulus
Copy link
Collaborator

📌 Commit 447d343 has been approved by japaric

@homunkulus
Copy link
Collaborator

⌛ Testing commit 447d343 with merge 447d343...

@homunkulus
Copy link
Collaborator

💔 Test failed - status-travis

old versions of gcc insert this into the executable but this causes
problem because this section places itself at the beginning of the .text
section thus filling the vector table with wrong values.
@japaric
Copy link
Owner Author

japaric commented Nov 17, 2016

@homunkulus r+

@homunkulus
Copy link
Collaborator

📌 Commit e88710d has been approved by japaric

@homunkulus
Copy link
Collaborator

⌛ Testing commit e88710d with merge e88710d...

@homunkulus
Copy link
Collaborator

💔 Test failed - status-travis

@japaric
Copy link
Owner Author

japaric commented Nov 17, 2016

I can't repro locally but I have a slightly older nightly: rustc 1.15.0-nightly (43006fcea 2016-11-15). I wonder if this is a regression in how rustc generates symbols ...

@japaric
Copy link
Owner Author

japaric commented Nov 18, 2016

@homunkulus try

@homunkulus
Copy link
Collaborator

⌛ Trying commit 9539289 with merge 9539289...

@homunkulus
Copy link
Collaborator

💔 Test failed - status-travis

@japaric
Copy link
Owner Author

japaric commented Nov 18, 2016

@homunkulus try

@homunkulus
Copy link
Collaborator

⌛ Trying commit d22404a with merge d22404a...

@homunkulus
Copy link
Collaborator

💔 Test failed - status-travis

@japaric
Copy link
Owner Author

japaric commented Nov 18, 2016

@homunkulus r+

@homunkulus
Copy link
Collaborator

📌 Commit eee6551 has been approved by japaric

@homunkulus
Copy link
Collaborator

⌛ Testing commit eee6551 with merge eee6551...

@homunkulus
Copy link
Collaborator

☀️ Test successful - status-travis
Approved by: japaric
Pushing eee6551 to master...

@homunkulus homunkulus merged commit eee6551 into master Nov 18, 2016
@japaric japaric deleted the discard branch November 18, 2016 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants