Port some platforms from llvm_asm to asm
#33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rivial The reason for this change is that `llvm_asm` is removed from nightly, so it doesn't compile anymore on any current compiler, while `asm` is being stabilised (currently stable on beta). The major omission in this commit is the linux x86 (32 bit) platform. The new `asm` macro doesn't allow the esi and ebp registers to be used as inputs or outputs or clobbers, which makes the port non-trivial for this platform. Similarly on armeabi the r6 register is not allowed as input, output or clobber.
niluxv
force-pushed
the
stable_asm_port
branch
from
2ede791
to
7e86d19
Compare
|
The issues mentioned for x86 and armeabi can be worked around by a trick similar to what is already deployed for |
|
Thanks! |
|
release v0.2.6 includes this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only ports platforms where the required changes are trivial.
The reason for this change is that
llvm_asmis removed from nightly, so itdoesn't compile any more on any current compiler, while
asmis being stabilised(currently stable on beta).
The major omission in this commit is the linux x86 (32 bit) platform. The new
asmmacro doesn't allow the esi and ebp registers to be used as inputs or outputs or
clobbers, which makes the port non-trivial for this platform. Similarly on armeabi
the r6 register is not allowed as input, output or clobber.