Skip to content

Commit

Permalink
Fixed listen_tcp function when receiving None or 0 in portrange argum…
Browse files Browse the repository at this point in the history
…ent. Closes scrapy#252
  • Loading branch information
pablohoffman committed Sep 27, 2010
1 parent 9206806 commit 49ffe52
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion scrapy/utils/reactor.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

def listen_tcp(portrange, factory):
"""Like reactor.listenTCP but tries different ports in a range."""
assert len(portrange) in [1, 2], "invalid portrange: %s" % portrange
assert len(portrange) <= 2, "invalid portrange: %s" % portrange
if not hasattr(portrange, '__iter__'):
return reactor.listenTCP(portrange, factory)
if not portrange:
return reactor.listenTCP(0, factory)
if len(portrange) == 1:
return reactor.listenTCP(portrange[0], factory)
for x in range(portrange[0], portrange[1]+1):
Expand Down

0 comments on commit 49ffe52

Please sign in to comment.